Repository navigation
Conversation
Install ZCode as a Portable-only host under .zcode/skills, with a Pi-shaped adapter manifest and an Agent-based adapter guide that guards against the built-in CreateWorkflow tool. Classic install is rejected with a skills install hint; runtime-core selects the adapter by host identity and Base directory rather than the mere presence of Agent.
|
LoopForge PR Review — head Verdict: ✅ Pass
|
Yanami-2K
left a comment
There was a problem hiding this comment.
核对了 #125 的 Local 部分:“至少支持一种安装路径”由 loopforge skills install zcode 提供,安装到 .zcode/skills/;Classic 安装会被拒绝并给出可执行的提示;不会修改 ~/.zcode。editions.py、core.py、targets/zcode.py 沿用了 codex/hermes 的现有模式。runtime-core.md 要求同时匹配宿主身份和 Base directory,避免与 Claude Code 的 Agent 工具误匹配。test_zcode_installs_project_skills_and_rejects_classic 断言了安装产物、入口、adapter manifest 和拒绝 Classic 时的提示文案,smoke-install 也覆盖了 zcode。CI 全绿,批准。
一个不阻塞的小问题:local/README.md 里“use skills install pi, skills install dsh, or skills install hermes, or skills install zcode”重复了 or,可以顺手改成“skills install pi, dsh, hermes, or zcode”。
|
@Yanami-2K Thanks for the review! Commit Regarding the 4 failing checks on
Since pushing 中文说明@Yanami-2K 感谢 Review!提交 关于
由于推送 |
|
LoopForge PR Review Bot — reviewed commit Verdict: PASS ✅ What I checked
CI note (not attributed to this PR): the 4 failing required checks on this head SHA — No action needed from the author for this version; the CI red X should clear once #886 lands. |
Yanami-2K
left a comment
There was a problem hiding this comment.
已读完 19 个文件的 diff。ZCode Portable 接入本身(editions.py 加 host/入口、core.py 把 zcode 安装到 .zcode/skills、Classic 拒绝提示、adapter.md/manifest.json、runtime-core.md 按 Base directory 消歧、test_zcode_installs_project_skills_and_rejects_classic 和 smoke-install 断言)没有发现正确性问题。阻塞项只有 CI:
- CI 失败(checksState=failure):head fc42f54 上
validate (3.8)、e2e (ubuntu-latest, python 3.8, node 22)、e2e-browser (dashboard in Chromium)、e2e-required失败。这组失败与同期 #888/#902/#903 完全一致,大概率是ubuntu-latest切到 26.04 导致的 Python 3.8 / Playwright 安装问题(#885,修复在 #886),不是本 PR 引入。建议:等 #886 合入后 rebase 到最新 main 重跑 CI;如果validate (3.8)仍失败,请检查local/src/devflow_cli和local/tests/test_installer.py的新增代码是否用了 3.8 不支持的语法。
CI 全绿后可以重新请求审查。
Summary
Implements ZCode Local host integration for LoopForge Portable Edition (resolves #125 Local half).
Key Changes
zcodetarget todevflow_cli/targets/zcode.pyandeditions.py, installing portable skills under<project>/.zcode/skills/. Rejects Classic installation with an actionable hint to runloopforge skills install zcode.local/skills/devflow/adapters/zcode/adapter.mdandmanifest.json. Explicitly guides the agent to drive DevFlow via theworkflow_state.pystate machine, and guards against invoking ZCode built-inCreateWorkflow..zcode/skills/devflow) rather than generic agent availability, avoiding false matches with Claude Code.docs/local/compatibility.md,architecture.md,usage.md,local/README.md, and rootREADME.mdwith ZCode entrypoint (/skill devflow "<task>").Verification Evidence (Exit Code 0)
python3 scripts/build-classic-hosts.py --check-> OKbash scripts/validate.sh-> Validation passed (6/6 steps)bash scripts/smoke-install.sh-> Smoke install passed (30 portable + 25 CLI tests)bash scripts/e2e.sh-> 29 tests passedbash scripts/test-observability.sh-> 393 tests passed (131 per host)PYTHONPATH=src python3 -m unittest tests.test_installer-> 23 tests passedzcode -p "/skill devflow ..."in/tmp/zcode-devflow-demo, completingPHASE-0 -> SOLO -> SUMMARYwith 6 unit tests passed.sess_343a27d6-9550-45fe-8213-90601358c52d) running onmemexproject; completed small route with 6/6 tests passed and artifacts validated.openai/gpt-6.1-sol#high(13 boundary tests passed); refined async wait semantics and timeout error handling in adapter.中文说明
概述
实现 LoopForge 本地工作流对 ZCode 本地宿主的接入支持(解决 #125 本地宿主部分)。
核心变更
devflow_cli/targets/zcode.py与editions.py中增加zcode目标,将 Portable 技能安装至<project>/.zcode/skills/目录。Classic 安装执行拦截并输出可执行指引:loopforge skills install zcode。local/skills/devflow/adapters/zcode/adapter.md与manifest.json,明确指导 Agent 使用workflow_state.py状态机,禁止调用 ZCode 内置的CreateWorkflow。.zcode/skills/devflow)选择适配器,而非仅凭是否存在 Agent 工具,避免与 Claude Code 产生误匹配。docs/local/compatibility.md、architecture.md、usage.md、local/README.md与根目录README.md,增加 ZCode 调起入口(/skill devflow "<需求>")。确证凭据(退出码 0)
python3 scripts/build-classic-hosts.py --check:通过bash scripts/validate.sh:通过(6/6 检查通过)bash scripts/smoke-install.sh:通过(30 项 Portable + 25 项 CLI 测试)bash scripts/e2e.sh:29 项测试全部通过bash scripts/test-observability.sh:393 项测试全部通过(三宿主各 131 项)PYTHONPATH=src python3 -m unittest tests.test_installer:23 项测试全部通过/tmp/zcode-devflow-demo运行zcode -p "/skill devflow ...",完整走通PHASE-0 -> SOLO -> SUMMARY,6 项单测全绿。sess_343a27d6-9550-45fe-8213-90601358c52d)中跑通完整流程,6 项单测通过且产物通过双门禁校验。openai/gpt-6.1-sol#high独立复审(13 项补充边界测试全部通过),并按审查意见补强了异步等待与超时错误恢复契约。