Repository navigation
fix(chat): stop refetching unavailable text diffs - #941
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
3 tasks done
Yanami-2K
approved these changes
Nov 16, 2026
Yanami-2K
left a comment
Collaborator
There was a problem hiding this comment.
核对了 chatbot/src/ChangesPanel.jsx:用 Object.hasOwn(patches, path) 区分“已经拉取过但结果是 null”和“还没拉取”,并把 effect 依赖从整个 patches 收窄到 cached,这样二进制或超大文件不会反复重新请求。新测试第一次返回 null、之后返回永不完成的 Promise,并断言只调用了一次且显示了无文本改动的提示,确实能捕捉到原来的重复请求。它和 #938 的改动互补,作者也已用 merge-tree 确认两者可以干净合并。
5 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The chat changes panel fetched a file again whenever its server response had no text diff. The result was cached as null, then the load effect treated null as a cache miss. This could repeat for binary or oversized files for as long as the detail panel stayed open. The panel now distinguishes a completed empty result from an unfetched file.
Scope
Validation
git diff --checkpassed.git merge-treealso combined this change with fix(chat): scope workspace changes to their run #938. Full public browser and platform suites were not run.Safety