Repository navigation
feat(workspaces): allow binding project SOP workspaces via workspaceRunId - #974
Open
crispinhu27 wants to merge 2 commits into
Open
crispinhu27 wants to merge 2 commits into
crispinhu27 wants to merge 2 commits into
Conversation
…unId - Restore optional workspaceRunId on workbench_workspace_open to bind a same-project SOP run (resolving child SOPs to their parent workspace) or an earlier own conversation workspace. - Enforce execution-machine matching with explicit machine names when the target SOP lives on a different runner/cloud host, and validate Docker/native sandbox drivers. - Restore reclaimed checkpoints on open, keep borrowed SOP runs out of OwnWorkspaceRunIDs so deleting a conversation never deletes the SOP workspace, and preserve edits made in chat across SOP Resume / Retry. - Roll back session workspace binding if opening/preparing a switched target workspace fails.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Collaborator
Author
03:00 轮:同步最新 main(head
|
| AI 工作台首页 | 运行记录 |
|---|---|
![]() |
![]() |
CI 在新 head 上重新运行中。本 PR 目前与 main 无冲突,仍需维护者评审批准后才能合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
workspaceRunIdonworkbench_workspace_openso an ordinary project conversation on the same execution machine can bind directly to a historical/paused SOP run's workspace (automatically resolving child SOPs to their parent workspace viaengine.WorkspaceRunID) or switch back to an earlier workspace opened by the same conversation.ExecutionRunnerID) with clear machine-name errors when source SOP and conversation are on different machines, and validate Docker/native sandbox drivers.Retry/runs_resume).OwnWorkspaceRunIDs, so deleting an ordinary conversation never deletes the SOP workspace.workspaceTurnContext,assistantNativeSystemPrompt,docs/conversation-workspaces.md, and add unit/integration tests ininternal/httpapi/assistant_workspace_resume_test.go.Testing
go test -race -count=1 ./internal/httpapi -run 'TestWorkspaceOpen|TestBorrowedSOP|TestConversationSandbox|TestTurnContextOffersWorkspaces|TestNativePromptsAreToolFirst|TestConversationWorkspaceTools|TestDeletingConversationRemovesItsWorkspace|TestOpeningSOPWorkspaceOnlyHandsOffWhenStopped|TestAssistantWorkspaceTurn'go test -count=1 ./internal/httpapi(passed; Docker-gated tests skipped withoutAGENTFLOW_TEST_DOCKER=1)go test -race -count=1 ./internal/engine -run 'TestMainBotControlReusesRunWorkspaceLease|TestConversationWorkspace|TestWorkspaceRestore|TestWorkspaceCheckpoint|TestMaterializeConversationWorkspace'go test -count=1 ./internal/repo ./internal/domainnpm --prefix chatbot run build && npm --prefix chatbot test(56 files, 373 tests)go vet ./...,go build ./...,python3 scripts/check-public.py