Repository navigation
Conversation
Strip legacy URL credentials and one-line untrusted catalog text from workspace hints and run diagnostics. Add coverage for credential-bearing repository rows.
Protect the workspaceRunID rollback write with workspaceMu so failed workspace opens cannot race with concurrent workspace tools.
Allow the GitHub workspace askpass helper to answer https://github.com:443 prompts while still rejecting other ports and lookalike hosts. Extend the existing token-scope regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
workspaceRunIDwithworkspaceMu.Scope
Compatibility
No schema, API, or runner-protocol changes. The askpass change only broadens an exact GitHub HTTPS host match from
github.comtogithub.complus the explicit default port443; other hosts and ports remain rejected.Validation
Executed locally:
go test ./internal/domain -count=1 -timeout=300s— passedGOOS=linux GOARCH=amd64 go test -c ./internal/httpapi— passedGOOS=linux GOARCH=amd64 go test -c ./internal/runtime— passedgo vet ./internal/httpapi ./internal/runtime— passed with Linux targetgit diff --check— passedNot run locally:
go test -p=2 ./...and Docker/native integration tests: this host is Windows and the project’s runtime imports Linux-only syscall APIs; Docker is not installed.python3 scripts/check-public.py,bash scripts/scan-secrets.sh, and browser acceptance were not run because Python/Bash prerequisites are not available on this host.Safety