Repository navigation
fix(auth): keep polling through transient token-endpoint errors - #13
Merged
Merged
Conversation
pollToken treated a rejected fetch or an unparseable token response as a terminal failure and aborted the device login with "unreadable token response" on the first network blip. Classify transport and parse failures separately, keep polling with the existing interval until the device code expires, and abort only on terminal OAuth errors. The timeout message now reports how many network errors occurred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pollToken(src/auth.ts:159-207) turned transport failures into terminal failures: a rejectedfetchor a non-JSON body producedbody = null, and theelse ifbranch threwlogin failed: unreadable token responseon the first network blip. A user on a flaky network or behind a proxy had the device login aborted mid-flow and had to restart with a new code.Change
transportFailuresand keeps polling.expires_inwith the existing interval andslow_downbackoff.errorother thanauthorization_pending/slow_down).Tests
poll survives transient transport failures(fetch rejects twice, then pends, then succeeds)poll keeps polling after unparseable token responsespoll still aborts on terminal OAuth errors after a transport blippoll reports transport failures when it times outVerification
npm cinpm run buildnpm test— 24/24 pass