Repository navigation
Run resolver test stubs through the shell - #631
Merged
tinder-maxwellelliott merged 1 commit intoNov 6, 2026
Merged
tinder-maxwellelliott merged 1 commit into
tinder-maxwellelliott merged 1 commit into
Conversation
The shared Unix resolver stub runs from a newly written executable. Two Linux CI failures lost its first mapping invocation. The resolver accepts an empty mapping when the command fails, so a later successful lookup can leave the missing log entry as the only evidence. Apply aa005b3's shell-execution approach to the four remaining callers of this stub. Run /bin/sh with a fixed script and pass the log path, response and Bazel arguments separately. Assisted by Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four Unix tests that share the resolver stub execute a newly written temporary file. Two Linux CI runs lost the initial mapping invocation. The resolver uses an empty mapping after a command failure, so the fallback query in #630 still found the requested repository. These jobs did not record the underlying errno. 1 2
Extend #568’s fix to this shared stub. Run a fixed script through the installed
/bin/shand pass the log path, mock response and Bazel arguments separately. The tests still check the full sequence of commands, including caller-supplied startup options and the empty root repository argument.Assisted by Codex.