Repository navigation
Hash local BUILD overlays for http_archive - #634
Merged
tinder-maxwellelliott merged 1 commit intoNov 7, 2026
Merged
tinder-maxwellelliott merged 1 commit into
tinder-maxwellelliott merged 1 commit into
Conversation
An http_archive can read build_file from a local_repository while the archive checksum stays unchanged. Repository input hashing follows files in the main workspace and misses this external overlay, so an edit can change a built output without selecting the archive's direct readers. Hash the named regular file when the evaluated source records agree on a native or standard local_repository path. Require the standard http_archive origin and a LABEL build_file. Invalidate cached graphs and partial recipes recorded with the old digest. The regression changes two overlays of the same archive independently and checks each direct reader. It also verifies that a tracked overlay edit in the workspace rebuilds a partial graph to match fresh generation. Assisted by Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An http_archive can read build_file from a local_repository while the archive checksum stays unchanged. Repository input hashing follows files in the main workspace and misses this external overlay, so an edit can change a built output without selecting the archive's direct readers.
Hash the named regular file when the evaluated source records agree on a native or standard local_repository path. Require the standard http_archive origin and a LABEL build_file. Invalidate cached graphs and partial recipes recorded with the old digest.
The regression changes two overlays of the same archive independently and checks each direct reader. It also verifies that a tracked overlay edit in the workspace rebuilds a partial graph to match fresh generation.
Assisted by Codex.