Skip to content

Ignore local proof folders and stray target worktrees - #264

Closed
itz4blitz wants to merge 1 commit into
mainfrom
chore/ignore-local-proofs
Closed

itz4blitz wants to merge 1 commit into
mainfrom
chore/ignore-local-proofs

Conversation

@itz4blitz

Copy link
Copy Markdown
Collaborator

What changed and why

Local ship-it evidence under _proof/ and a stray target-wt/ directory were showing up as untracked work on every checkout. They are outputs, the same kind as reports/, and they stay on disk. Git now ignores them.

Type

  • chore

Platforms

Proof

No behavior change. Nothing for the lab to record.

Compatibility

No protocol or client change.

Risk and rollback

A proof folder someone meant to commit would be ignored. Revert this commit to track it again.

Release note

Local proof folders are no longer offered as untracked files.

`_proof/` and `target-wt/` are ship-it evidence and local build output. They were showing up as untracked work on every checkout.
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Tiny Code Review

⚠️ Code review unavailable · run

the AI provider rate-limited the request

This is advice, not a gate. Re-run with the agent:review label or a /review comment.

@unRekable unRekable left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

🟡 1 finding (0 blocking).

The change adds two root-anchored ignore entries so local ship-it evidence and a stray worktree target directory stay off git status, following the existing /reports/ pattern; target-wt/ has no tracked content and is fine. The problem is /_proof/: it matches five files already tracked on main (_proof/README.md plus four PNGs). The rule does nothing to those tracked files, so their status noise remains, and any future proof writeup that follows the pattern that same README documents gets silently skipped by git add . with no error.

Residual risk

  • target-wt/ is not created or documented by anything in the tree today, so the rule encodes a local convention; if the tooling's name drifts, a new stray directory will reappear as untracked noise.
  • e2e/gate.json has release_proof: "report"; if a release captain ever needs proof files from _proof/ shipped with a change, git add will now skip them and require -f or a path outside the ignore.

Comment thread .gitignore

# UAT and design screenshots are outputs, not sources.
/reports/
/_proof/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Major: This rule matches five files the repository tracks on main (_proof/README.md, inbox.png, inbox-unread.png, switcher.png, telegram-mute-bell.png). Ignore rules do not untrack them, so their modifications still show in git status, while any new proof writeup added next to them — the exact pattern that README documents — is silently left out of git add . and can disappear from a PR without an error. Smallest fix: make the tree agree with the rule in this PR by untracking the folder (git rm -r --cached _proof/), or keep the tracked baselines and scope the rule instead of ignoring the directory wholesale.

@itz4blitz

Copy link
Copy Markdown
Collaborator Author

Superseded by and merged in #903 (d387971 — Release 2026-11-20 combined PR).

@itz4blitz itz4blitz closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants