Skip to content

Google Messages: only one file can be sent per message - #829

Closed
itz4blitz wants to merge 1 commit into
mainfrom
issue/689-several-files
Closed

itz4blitz wants to merge 1 commit into
mainfrom
issue/689-several-files

Conversation

@itz4blitz

Copy link
Copy Markdown
Collaborator

What changed and why

Google Messages can send up to ten files in one message. The phone is asked once, progress is reported, and the send can be cancelled before that ask. There is no warning that a photo will leave as an MMS copy, because the published conversation layout has no SMS, MMS, or RCS field.

Tested with cargo test -p chatd --no-default-features for the new three-file send (including cancel) and the existing one-file send, and with cargo clippy -p chatd --no-default-features --all-targets. A live Google account was not tested.

Type

  • feature
  • fix
  • perf
  • refactor
  • chore
  • docs

Platforms

  • windows
  • macos
  • linux
  • android
  • ios

Proof

Scenario: e2e/scenarios/messages-several-files

Lab run:

Compatibility

No protocol change. Each file is still capped at 100 MB. An older client keeps sending one file.

Risk and rollback

A file that fails to seal or upload is named, and the phone is not asked to send the message. Revert this change to go back to one file at a time.

Release note

Google Messages can send up to ten files in one message.

Closes #689

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Tiny Code Review

⚠️ Code review unavailable · run

the AI provider rate-limited the request

This is advice, not a gate. Re-run with the agent:review label or a /review comment.

@unRekable unRekable left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

🟢 No findings.

The change moves Google Messages file sends onto the repository's standard upload pipeline: files stream in 32 KiB chunks into the existing AES-256-GCM seal format (byte-identical for one file, fresh nonce and last-flag AAD per chunk), upload, then one RPC names every part, with the 100 MB and 10-file caps enforced where the rest of chatd enforces them and cancel wired through the shared Upload. The design holds: no plaintext is fully buffered, the process boundaries are untouched, the added CancelSend arm matches the upload module's documented contract, and the encoder, chunked seal, multi-file send, over-limit refusal and cancel are all tested. The one real unknown is the phone side of the repeated-field wire layout, which no live account has seen.

Residual risk

  • The several-files layout (repeated field 10) has never been sent to a real Google Messages phone; the proof and tests validate tinyclient's own encoder only. If the phone renders one file or refuses the send, that surfaces in production and the rollback is reverting this PR.
  • If one file of several fails after earlier files uploaded, the already-uploaded parts stay on Google's storage with no cleanup call, and a retry re-uploads everything.
  • A send holds the whole sealed file (up to about 100 MB of ciphertext) in memory while bugle uploads it. That is still better than the base, which held the plaintext too, but it is the one unbounded allocation left on this path.

@itz4blitz

Copy link
Copy Markdown
Collaborator Author

Superseded by and merged in #903 (d387971 — Release 2026-11-20 combined PR).

@itz4blitz itz4blitz closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Messages: only one file can be sent per message

2 participants