Repository navigation
Conversation
Tiny Code Reviewthe AI provider rate-limited the request This is advice, not a gate. Re-run with the |
unRekable
left a comment
There was a problem hiding this comment.
Code Review
🟢 No findings.
The diff gives the Google Messages adapter the SetMute handler the other adapters already have: Mentions and Nothing map to the conversation's stored muted flag exactly as Telegram maps them, reported through Context::muted so the window is told and chatd's own notification rules follow (notify.rs::decide already suppresses on conversation.muted). The scripted-phone recording added in heard_live is gated on the fake-phone env var, so production behavior changes only in that a previously Unsupported command now works. There is no protocol, migration, or outbound-host change, so older peers see no difference. Tests cover the mute over the real request path, and the e2e scenario follows the established prove pattern and fails on a build without the change.
Residual risk
- Until the shell gains a Mute entry for Messages (the body discloses this as outside the change), the new handler is reachable only through the request path, so users cannot yet mute a Messages chat from the window itself.
- Messages never sets mentions_me, so a chat left at Mentions-only can never notify here even if Google later delivers mention data; the doc comment on quiet records the intent, worth revisiting if the phone ever grows mentions.
- heard_live's store read uses .ok(), so a transient store error would record a notify line for a muted chat; only the scripted test recording is affected, since production notification decisions go through notify.rs::decide.
454c113 to
4058a9c
Compare
What changed and why
A Google Messages chat can be muted on this computer. Nothing and mentions-only both stay quiet, because Messages has no mention notifications, and allowing every notification lets a new message through. The published conversation layout has no mute field, so the phone's own mute is not read and a mute is not sent to the phone.
The person menu still says "Stays on your phone" and still omits Mute. That control lives in the shell, outside this change.
Tested with
cargo test -p chatd --no-default-featuresfor a muted chat recording no notification while an open chat does, and withcargo clippy -p chatd --no-default-features --all-targets. A live Google account was not tested, and the shell menu was not changed.Type
Platforms
Proof
Scenario: e2e/scenarios/messages-mute
Lab run:
Compatibility
No protocol change. The mute is the conversation flag this client already stores. An older client leaves the chat unmuted.
Risk and rollback
A mute here does not silence the phone, and a mute on the phone still notifies from this computer. Revert this change to leave Messages mute unsupported.
Release note
A Google Messages chat can be muted on this computer.
Closes #690