Skip to content

Slack: Zoom, Meet and Teams call cards, and old Slack calls, show as an empty placeholder - #837

Closed
itz4blitz wants to merge 1 commit into
mainfrom
issue/555-slack-call-cards
Closed

itz4blitz wants to merge 1 commit into
mainfrom
issue/555-slack-call-cards

Conversation

@itz4blitz

Copy link
Copy Markdown
Collaborator

What changed and why

A Slack call from Zoom, Meet, Teams or Webex is drawn as a card: the meeting name, who is in it or how long it ran, and a Join link that opens the meeting. An old Slack call reads as a call that happened, with its length. It is no longer an empty interactive placeholder.

Type

  • feature
  • fix
  • perf
  • refactor
  • chore
  • docs

Platforms

  • windows
  • macos
  • linux
  • android
  • ios

Proof

Scenario: e2e/scenarios/slack-call-cards

Lab run: the lab records this scenario and posts e2e-proof.

Compatibility

No protocol field was added. An older client is unchanged. No server change.

Risk and rollback

A call block that Slack has not filled in (call.v1 missing) stays the old placeholder. Revert this commit to restore that reading for every call.

Release note

Slack meetings from Zoom, Meet, Teams and Webex show as a card with a Join link, and an old Slack call says how long it ran.

Closes #555

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Tiny Code Review

⚠️ Code review unavailable · run

the AI provider rate-limited the request

This is advice, not a gate. Re-run with the agent:review label or a /review comment.

@unRekable unRekable left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

🟢 No findings.

The Slack adapter renders a resolved call block (call.v1) as a protocol Card with a Join link preview, and old sh_room_created calls as "A call happened ..." while huddles keep their line. The design follows the adapter's existing framed-card and huddle patterns, stays inside chatd, adds no wire fields, and is covered by a new integration test plus a prove driver that matches the existing TINYCLIENT_PROVE drivers exactly. No blocker found: arithmetic is guarded, no input-reachable panic, no boundary crossed, nothing fetches the join URL, and the new shell scripts are LF. Two small behavior notes went to residual risk, not findings.

Residual risk

  • A call block with only call_id (no call.v1) mixed into a message that also draws text is now dropped without any sign: the new "call" => {} arm no longer sets undrawn, so the row loses the "Open in Slack" link it used to gain. A standalone unfilled call still becomes an Unsupported placeholder, but its wording changes from "An interactive message" to "A message tinyclient cannot show yet", so the PR body's "stays the old placeholder" holds only for the placeholder kind, not the words.
  • (end - start) / 60 in the new legacy_call (and the shipped huddle) can overflow i64 and panic in a debug build if Slack ever sent extreme date_start/date_end; a release build wraps and the minutes > 0 guard swallows it. This copies the existing shipped pattern rather than introducing it.
  • join_url and an unknown lowercased media_backend_type (as the preview's site) reach the window uncapped, the same way Slack's own from_url/service_name previews already do; Message::bound caps only the card's title and text.
  • http:// join links are accepted alongside https://; Slack serves https in practice and the link opens only on click, so nothing is fetched on arrival.

…call happened.

A Zoom, Meet, Teams or Webex call block is a card with who is in it, or how long it ran, and a Join link. An old Slack call reads as a call that happened. A call id with nothing filled in stays the placeholder.

Closes #555
@itz4blitz

Copy link
Copy Markdown
Collaborator Author

Superseded by and merged in #903 (d387971 — Release 2026-11-20 combined PR).

@itz4blitz itz4blitz closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack: Zoom, Meet and Teams call cards, and old Slack calls, show as an empty placeholder

2 participants