Repository navigation
Conversation
Tiny Code Reviewthe AI provider rate-limited the request This is advice, not a gate. Re-run with the |
unRekable
left a comment
There was a problem hiding this comment.
Code Review
🟢 No findings.
The Slack adapter renders a resolved call block (call.v1) as a protocol Card with a Join link preview, and old sh_room_created calls as "A call happened ..." while huddles keep their line. The design follows the adapter's existing framed-card and huddle patterns, stays inside chatd, adds no wire fields, and is covered by a new integration test plus a prove driver that matches the existing TINYCLIENT_PROVE drivers exactly. No blocker found: arithmetic is guarded, no input-reachable panic, no boundary crossed, nothing fetches the join URL, and the new shell scripts are LF. Two small behavior notes went to residual risk, not findings.
Residual risk
- A
callblock with onlycall_id(nocall.v1) mixed into a message that also draws text is now dropped without any sign: the new"call" => {}arm no longer setsundrawn, so the row loses the "Open in Slack" link it used to gain. A standalone unfilled call still becomes an Unsupported placeholder, but its wording changes from "An interactive message" to "A message tinyclient cannot show yet", so the PR body's "stays the old placeholder" holds only for the placeholder kind, not the words. (end - start) / 60in the newlegacy_call(and the shippedhuddle) can overflow i64 and panic in a debug build if Slack ever sent extremedate_start/date_end; a release build wraps and theminutes > 0guard swallows it. This copies the existing shipped pattern rather than introducing it.join_urland an unknown lowercasedmedia_backend_type(as the preview'ssite) reach the window uncapped, the same way Slack's ownfrom_url/service_namepreviews already do;Message::boundcaps only the card's title and text.http://join links are accepted alongsidehttps://; Slack serves https in practice and the link opens only on click, so nothing is fetched on arrival.
…call happened. A Zoom, Meet, Teams or Webex call block is a card with who is in it, or how long it ran, and a Join link. An old Slack call reads as a call that happened. A call id with nothing filled in stays the placeholder. Closes #555
74df352 to
a782521
Compare
What changed and why
A Slack call from Zoom, Meet, Teams or Webex is drawn as a card: the meeting name, who is in it or how long it ran, and a Join link that opens the meeting. An old Slack call reads as a call that happened, with its length. It is no longer an empty interactive placeholder.
Type
Platforms
Proof
Scenario: e2e/scenarios/slack-call-cards
Lab run: the lab records this scenario and posts e2e-proof.
Compatibility
No protocol field was added. An older client is unchanged. No server change.
Risk and rollback
A call block that Slack has not filled in (
call.v1missing) stays the old placeholder. Revert this commit to restore that reading for every call.Release note
Slack meetings from Zoom, Meet, Teams and Webex show as a card with a Join link, and an old Slack call says how long it ran.
Closes #555