Repository navigation
Conversation
Tiny Code Reviewthe AI provider rate-limited the request This is advice, not a gate. Re-run with the |
unRekable
left a comment
There was a problem hiding this comment.
Code Review
🟢 No findings.
The change routes any Telegram photo or document carrying ttl_seconds away from the fetch queue into the existing unsupported placeholder, with kind detection from the media flags and then the document attributes. The design holds: arm order keeps the expired labels ahead of the new ones, the map catch-all produces the locked row with a deep link into Telegram's own app, and a unit test plus the lab scenario cover photo, voice, video, and round variants, including the ordinary photo that must keep fetching. No protocol, process boundary, or fetch path is touched. Nothing failed.
Residual risk
- The scenario trusts the in-process check: chatd exits 0 only on prove_view_once's own assertions, so the driver never independently observes the store or the fetch queue; removing an assertion later would pass vacuously.
- Official Telegram clients still open timed media once; tinyclient now shows only the locked row with a deep link. Users who opened timed media here before lose that, which the PR body accepts.
- ttl_seconds is also how secret-chat media is marked; the adapter does not support secret chats, so that payload shape is untested against the new locked arms.
A photo, video, or voice message with a timer reads as a locked row and queues no file. An ordinary photo is still fetched. Closes #546
b9dbae2 to
d0a3e77
Compare
What changed and why
A view-once photo, video, or voice message, and media on a shorter timer, shows as a locked row and is not downloaded. It opens in Telegram's own app. An ordinary photo is still fetched. Sending media with a timer is unchanged, because the send request has no field for one.
Type
Platforms
Proof
Scenario: e2e/scenarios/telegram-view-once
Lab run:
Compatibility
No protocol change. An older client and an older server are unchanged.
Risk and rollback
View-once and timed media no longer open here. Revert this commit to fetch them again.
Release note
View-once Telegram photos, videos, and voice messages stay locked instead of opening like ordinary files.