Skip to content

Telegram: view-once photos and videos open like normal ones; cannot send with a timer - #838

Closed
itz4blitz wants to merge 1 commit into
mainfrom
issue/546-telegram-view-once
Closed

itz4blitz wants to merge 1 commit into
mainfrom
issue/546-telegram-view-once

Conversation

@itz4blitz

Copy link
Copy Markdown
Collaborator

What changed and why

A view-once photo, video, or voice message, and media on a shorter timer, shows as a locked row and is not downloaded. It opens in Telegram's own app. An ordinary photo is still fetched. Sending media with a timer is unchanged, because the send request has no field for one.

Type

  • fix
  • feature
  • perf
  • refactor
  • chore
  • docs

Platforms

  • windows
  • macos
  • linux
  • android
  • ios

Proof

Scenario: e2e/scenarios/telegram-view-once

Lab run:

Compatibility

No protocol change. An older client and an older server are unchanged.

Risk and rollback

View-once and timed media no longer open here. Revert this commit to fetch them again.

Release note

View-once Telegram photos, videos, and voice messages stay locked instead of opening like ordinary files.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Tiny Code Review

⚠️ Code review unavailable · run

the AI provider rate-limited the request

This is advice, not a gate. Re-run with the agent:review label or a /review comment.

@unRekable unRekable left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

🟢 No findings.

The change routes any Telegram photo or document carrying ttl_seconds away from the fetch queue into the existing unsupported placeholder, with kind detection from the media flags and then the document attributes. The design holds: arm order keeps the expired labels ahead of the new ones, the map catch-all produces the locked row with a deep link into Telegram's own app, and a unit test plus the lab scenario cover photo, voice, video, and round variants, including the ordinary photo that must keep fetching. No protocol, process boundary, or fetch path is touched. Nothing failed.

Residual risk

  • The scenario trusts the in-process check: chatd exits 0 only on prove_view_once's own assertions, so the driver never independently observes the store or the fetch queue; removing an assertion later would pass vacuously.
  • Official Telegram clients still open timed media once; tinyclient now shows only the locked row with a deep link. Users who opened timed media here before lose that, which the PR body accepts.
  • ttl_seconds is also how secret-chat media is marked; the adapter does not support secret chats, so that payload shape is untested against the new locked arms.

A photo, video, or voice message with a timer reads as a locked row and queues no file. An ordinary photo is still fetched.

Closes #546
@itz4blitz

Copy link
Copy Markdown
Collaborator Author

Superseded by and merged in #903 (d387971 — Release 2026-11-20 combined PR).

@itz4blitz itz4blitz closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants