Skip to content

Teams: a team has no info pane or member list; a channel has no Members button - #847

Closed
itz4blitz wants to merge 1 commit into
mainfrom
issue/668-teams-info
Closed

itz4blitz wants to merge 1 commit into
mainfrom
issue/668-teams-info

Conversation

@itz4blitz

Copy link
Copy Markdown
Collaborator

What changed and why

Opening a team now shows its description, how many people are in it, and your role. The member list for a team is split into Owners, Members and Guests. The channel header still has no Members button, because that control is drawn by the shell. A team still has no picture: the list carries a picture tag, not an address.

Type

  • feature
  • fix
  • perf
  • refactor
  • chore
  • docs

Platforms

  • windows
  • macos
  • linux
  • android
  • ios

Proof

Scenario: e2e/scenarios/teams-team-info

Lab run: TINYCLIENT_PROVE=teams-team-info

Compatibility

No protocol field changed. An older client is unchanged. This only reads the team thread the adapter already fetches.

Risk and rollback

A role read wrong would call an owner a member, or the other way around. Revert this commit.

Release note

A Teams team shows its description, size and your role, and its member list is split into owners, members and guests.

Closes #668

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Tiny Code Review

⚠️ Code review unavailable · run

the AI provider rate-limited the request

This is advice, not a gate. Re-run with the agent:review label or a /review comment.

@unRekable unRekable left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

🟢 No findings.

The Teams adapter learns the two answers the window's existing SpaceInfo pane and member list already render: Command::SpaceInfo reads the team's General thread for its description, member count and my role, and Members sections a team roster into Owners, Members and Guests and sorts it, while chats keep one section. No wire types change; the description and role strings are capped where the repo already caps them (server.rs clips at 4000/100 and PROFILE_ROLES before the frame). The e2e scenario is a faithful twin of the shipped teams-reactions driver, the prove gate in main.rs matches its siblings, and the unit tests cover the sectioning and the info reply. I found no blocker or major; the only gap is that the sort order itself has no test that would fail without it.

Residual risk

  • The owners-then-members-then-guests ordering is not proven by anything that would fail without it: the fixture roster already sits in that order and prove_team_roster checks the section counts, not the sort. Dropping ordered.sort_by_key would still pass CI and the lab run.
  • team_thread also calls any thread whose id contains @thread.tacv2 a team when properties.threadType is missing. An old-format group chat with that id shape would get Owners/Members sections; cosmetic only, since every chat member is Admin.
  • role_label returns None for an unrecognized role, so a new Teams role string would leave the info pane with no role shown rather than the raw word.

@itz4blitz

Copy link
Copy Markdown
Collaborator Author

Superseded by and merged in #903 (d387971 — Release 2026-11-20 combined PR).

@itz4blitz itz4blitz closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Teams: a team has no info pane or member list; a channel has no Members button

2 participants