Skip to content

See who reacted to a message, per what each network carries (stage 1) - #900

Draft
unRekable wants to merge 5 commits into
mainfrom
draft/804-reactors
Draft

unRekable wants to merge 5 commits into
mainfrom
draft/804-reactors

Conversation

@unRekable

Copy link
Copy Markdown
Collaborator

What changed and why

A reaction now keeps who the network already said gave it, and the window shows them:
hovering a chip names them, right-clicking it (desktop) or long-pressing the message
(phone) opens the list grouped by emoji, and a row opens the person's card. Networks
whose payloads carry only a count — Discord's message payload and Tiny's history rows —
keep a plain chip and no list, and Telegram's hidden lists (channels, large groups) stay
hidden. Nothing is asked of any network: every name shown was already in a payload chatd
fetches today.

Type

  • feature
  • fix
  • perf
  • refactor
  • chore
  • docs

Platforms

  • windows
  • macos
  • linux
  • android
  • ios

Proof

Scenario: e2e/scenarios/reaction-reactors

Lab run:

Compatibility

Only the protocol grew: Reaction gained who: Vec<String>
(crates/protocol/src/message.rs), with #[serde(default)] and
skip_serializing_if = "Vec::is_empty", so an older frame reads and an older shell never
sees the field; an older chatd's frames read unchanged in the new shell. Message::bound
caps the list at REACTION_REACTORS (50) ids of 200 characters before the store writes a
row, so no network can size it past the existing caps. No request, route, or host is new:
no adapter makes a call it did not make before. Discord and Tiny deliberately stay
count-only; their follow-ups (a per-emoji Discord endpoint, a tinyserver wire change) are
named in the issue's staging, not smuggled in here.

Per-network honesty:

Network Chip list in this change Why
Slack names, from reactions[].users and the reaction events the payload names everyone
Teams names, from emotions[].users[].mri the same ids ReplyTo.person already carries
Telegram names where can_see_list is set and the message is not min; counts only otherwise Telegram hides the list in channels and large groups
Signal names, folded in from each reaction's sender every reaction arrives as its own event
Messages names, from the phone's participant list the Mark already carries who
Discord no list the payload counts only; a list needs one request per emoji (stage 2)
Tiny no list history rows carry counts only; a list needs a server wire change (stage 3)

A person the shell has not resolved yet reads "Someone", never a bare id; nothing from an
encrypted Tiny envelope is read, and reactions were never inside it.

Risk and rollback

The list is display-only: no send path reads who, so a wrong name costs nothing but a
look. The store's event merge is the shared piece — a wrong removal could leave a stale
name until the next payload replaces the list, which every network here sends on its next
message read. Rollback is a revert; old cached rows read back as count-only chips with no
migration.

Release note

Hover or long-press a reaction to see who gave it — on Slack, Teams, Telegram (where
Telegram shows it), Signal and Messages; a count-only chip stays a count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant