Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
A message can carry a reminder now, on the chatd side: "Remind me" sets a time, chatd keeps it
in its store, and when the time comes it posts one notification through the notifier it already
uses — silent, with the message's words and where it sits. A reminder survives a restart, fires
once, and is gone after it fired or was cancelled. Nothing goes to any network: the reminder is
the user's own ask. This is stage 1a of #790; the window's "Remind me…" menu item and picker are
stage 1b, on the wire this pull request adds and needing no further protocol change. The Later
list across networks stays stage 2.
Type
Platforms
Proof
Scenario: e2e/scenarios/message-remind
Lab run:
Compatibility
The wire only grew:
Request::Remind,Request::Reminders,Response::Reminders, andMessageReminderare new variants a peer that never sends them never sees;Remind.remind_atis
#[serde(default)]and left off when empty. An older chatd answers the new requests with anerror, which the window shows. The store grew one table, created
IF NOT EXISTSon every openwith no schema-version change and named in the rebuild drop next to
settings, so a schemabump rebuilds the cache and keeps reminders, and no shipped migration was edited.
Risk and rollback
chatd's notification thread computes its sleep from the store instead of sleeping for events
alone: one indexed
min(due)per event, capped, and no change to how it handles what arrives.If it misbehaves, reverting the pull request removes the table's reads and writes; the table
itself is inert rows that no older build touches. The cap (256 per account) bounds the table.
Reminders fire only while chatd runs; #802's quit notice should say so.
Release note
Reminders: keep a message on your mind — a reminder on a message tells you about it at the time
you picked, even after a restart.