Skip to content

ci(NOJIRA-123): name the build job after the node major so it matches the required check - #808

Merged
Jlougedo-TF merged 2 commits into
mainfrom
ci/required-check-node-24
Nov 16, 2026
Merged

Jlougedo-TF merged 2 commits into
mainfrom
ci/required-check-node-24

Conversation

@Jlougedo-TF

Copy link
Copy Markdown
Contributor

Why

Every PR is stuck on build-lint-test - node 24: Expected — Waiting for status to be reported.

The "Require status checks" ruleset expects a check named build-lint-test - node 24. Since #772 bumped the matrix to 24.21.0, the job has been named build-lint-test - node ${{ matrix.node_version }}, so it reports as build-lint-test - node 24.21.0. That name never matches, so the required check never arrives.

What

  • Add a node_major key next to node_version in the build-lint-test matrix, and use it in the job name. GitHub expressions can't cut a version string down to its major, so the major is kept as its own value.
  • setup-node still installs the exact 24.21.0.

A patch or minor bump now only touches node_version and doesn't rename the check. Moving to a new major (for example 26) changes node_major, and the ruleset must be updated at the same time.

After merging

The open Dependabot PRs (#793, #800, #801, #802, #804) have no workflow runs at all, because their last commits were pushed while Actions wasn't creating runs (2026-10-31 to 2026-11-09, and 2026-10-13). They need @dependabot rebase to get CI. Other open PRs pick up the new check name on their next push.

🤖 Generated with Claude Code

Jlougedo-TF and others added 2 commits November 16, 2026 18:03
…d check

The "Require status checks" ruleset expects `build-lint-test - node 24`, but
since #772 the job reported `build-lint-test - node 24.21.0`, leaving every PR
waiting for a check that never arrives. Keep the exact version pinned in the
matrix and use the major in the job name, so patch bumps no longer rename it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub expressions can't strip a version down to its major, so keep the exact
version in node_version for setup-node and add node_major for the job name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jlougedo-TF
Jlougedo-TF requested a review from a team as a code owner November 16, 2026 17:39
@pr-auditor

pr-auditor Bot commented Nov 16, 2026

Copy link
Copy Markdown

✅ Security Analysis Results

No security issues found. 1 files reviewed.


@pr-auditor rescan to re-run · Powered by Claude Sonnet 5.5 · Docs · #security-engineering-team

@jenkins-tf

Copy link
Copy Markdown
Collaborator

[BOT] Preview available with hash e0f3d920405da4230a9fabc4ac3ce7c2336ceebc here.

@Jlougedo-TF
Jlougedo-TF merged commit e1d9992 into main Nov 16, 2026
8 checks passed
@Jlougedo-TF
Jlougedo-TF deleted the ci/required-check-node-24 branch November 16, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants