Repository navigation
Conversation
matz3
reviewed
Oct 28, 2026
d3xter666
force-pushed
the
feat-extend-versioninfo-with-framework
branch
from
October 29, 2026 13:12
feaad4d to
81ac824
Compare
Member
Author
|
Blocked for now since it depends on: #1697 |
Note: this adjustment relies heavily on the implementation in #1697. Without it, the build will be failing since middlewareUtil.getResolvedFrameworkVersion() does not exists yet
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-839
Adds a top-level
framework: {name, version}object to the JSON producedby the
generateVersionInfotask of@ui5/builder.Resolution order in generateVersionInfo:
framework.name/framework.versionfromui5.yaml: emitsthat name and version (name must be "OpenUI5" or "SAPUI5").
Project.getId():any
@sapui5/dep wins immediately (SAPUI5, "");@openui5/depsaccumulate and yield the sap.ui.core version.
Note: The build is curently failing since
middlewareUtilis missing an API defined in https://github.com/UI5/cli/pull/1697/changes#diff-06a9c15663418255fca0a774c361570875c054ac822c61f5b95d67fcc27b4aacR176