Repository navigation
[TS] Retain classes with constant computed member keys - #448
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
Contributor
This was referenced Oct 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A class with
['values'],[1e2], or the standard-library[Symbol.iterator]currently retains independent bodies but receives an unsupported lifecycle, while the computed member itself is omitted. These supported keys now retain the class lifecycle and member bodies. String and numeric literal keys share their JavaScript property identity; initializers keep source order and later method definitions replace the same runtime key.FieldSignatureandMethodSignaturegain an optionalwellKnownSymbolmarker using the existing iterator identity. It survives frontend JSON and Kotlin conversion, so the symbol key and the ordinary string"Symbol.iterator"remain different signatures. ShadowedSymbol, dynamic key calls, computed accessors and accessor collisions, and synthetic lifecycle-name collisions remain explicit unsupported cases. Recognition of the standard-library key assumes the intrinsic globalSymbolhas not been replaced by external code.Validation:
checkLicenseMainpassed.checkLicenseTestreports existing violations in four files unchanged from the PR base:EtsTsStrictModeTest.kt,IdentityHashSetTest.kt,EtsFileDtoRenderingTest.kt, andEtsBlockCfgTargetsTest.kt.USVM dependency integration must make name-based method/field lookups respect this marker before updating the pin. This PR preserves frontend/IR identity and independent ordinary bodies; it does not implement general Symbol execution or establish improved symbolic coverage.
Closes #447.