Repository navigation
[TS PBT] Retain residual unknown-call diagnostics in property results - #608
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopped calls such as
Array::slice()andFloat64Array::constructoralready expose their callee, failure reason, and source statement throughTsUnknownCallEvent, but public property-search results retained only a generic unsupported-call message. The auxiliary relation-refutation prefix also dropped that event.The existing bounded runtime-limitation observer now retains actual stop/fresh-return fallback decisions with stable diagnostic codes, the original callee and failure reason, and the shared source-origin/fallback location. Successfully applied models do not become limitations. Runtime and unknown-call diagnostics share the existing 64 distinct-record limit and truncation marker. The auxiliary observer delegates the same event to that collector. No core, selector, execution policy, semantic model, or original experiment source was changed.
Validation: 33 focused tests pass across the public property search, auxiliary entry-refutation, and bounded observer contracts;
usvm-ts-pbt:detektMain,usvm-ts-pbt:detektTest,usvm-ts-fast-check:detektTest, andgit diff --checkpass. Both new public regressions fail on the parent observer because the expected diagnostic is absent, even though the engine logs the precise stopped call. JSON round trips retain the exact call/reason and original source lines for slice, typed-array construction, and the admission prefix. Controls cover applied models, fresh-return decisions, deduplication, fallback locations, and the shared diagnostic bound.Refs #555. Depends on #603, including its early-stop and canonical-confirmation follow-up.