Repository navigation
Preserve the experiment caller deadline through campaign startup - #616
Open
CaelmBleidd wants to merge 2 commits into
Open
CaelmBleidd wants to merge 2 commits into
CaelmBleidd wants to merge 2 commits into
Conversation
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experiment runner passed the campaign a fresh relative allocation, while its own cutoff had already started. Creating the JVM process could also extend
communicatebeyond that cutoff. The caller now passes the same absolute runner deadline through process creation and intocampaign-file, with a 1000 ms publication reserve inside it. The class replay reserve is subtracted once; native replay batches share the original total cutoff.Keep the original campaign configuration and controls. Existing relative
run_processcallers keep their behavior. Saved late, killed, and incomplete artifacts remain available with diagnostics and omissions, but receive no primary or native replay credit. Exit 1 remains eligible only for a confirmed original property violation, matchingcampaignExitCode.Stack base: #586 at
6e632337a9106fdfe84b29dc95c4356df864ed82. Runtime dependency: #615, which addsexternalDeadlineEpochMillisandpublicationReserveMillisto the CLI request. This PR deliberately contains only the Python caller and its focused tests; its standalone checks do not establish combined CLI end-to-end behavior.Validation: 15 focused Python tests pass, including fake-clock/Popen startup charging, delays between wall/monotonic clock reads, exhausted and shared cutoffs, reserve/control preservation, legitimate exit-1 faults, retained incomplete/late/killed evidence, native rejection, and invalid JSON.
git diff --checkpasses. No comparative campaign was run and frozen results were not modified.Refs #613.