Repository navigation
Conversation
zznop
added
Arch: x86
Use shared predicate definitions to render SSE and VEX scalar comparison pseudo-ops in disassembly and lift them to matching intrinsics, such as cmpeqsd(a, b).
Resolve ILIntrinsic.inputs and outputs by numeric intrinsic ID instead of display name. This prevents intrinsics with shared names, such as SSE and VEX comparisons, from exposing another intrinsic's signature.
zznop
force-pushed
the
test_float_cmp_pseudo_ops
branch
from
October 7, 2026 14:47
74a1796 to
828fbed
Compare
Member
Author
|
Updated PR to use an intrinsic for each pseudo op 
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floating-point comparisons were displayed as
_mm_cmpeq_*even when their predicate selected a different operation. This adds predicate-specific disassembly for SSE comparisons and VEX scalar comparisons, with symbolic predicate arguments in decompiled output. For example,cmpsd xmm0, xmm1, 6renders ascmpnlesd xmm0, xmm1, and its intrinsic uses_mm_cmp_sd(..., CMP_NLE_US).Disassembly and predicate enums share one definition table. Noncanonical immediate bytes remain explicit, and existing intrinsic IDs, operand widths, and lifting behavior are preserved.
This PR also contains a small fix for the Python API which now resolves
ILIntrinsic.inputsand.outputsby numeric ID, preventing SSE and VEX intrinsics with shared display names from returning each other’s metadata.Closes #4024
Before:
After:
