Repository navigation
fix(flight): supply the tenant label for query timing metrics - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Successful Arrow Flight
do_getcalls panic while recording query duration:QUERY_EXECUTE_TIMEdeclaresstreamandtenant_idlabels, while this handler supplies only the stream label. Clients receive a reset instead of the completed result.Supply
DEFAULT_TENANTas the second label. The handler already authorizes and executes with no tenant override, so this matches its execution context. The metric definition, query behavior, and Flight wire format are unchanged.This PR is limited to two lines in
src/handlers/airplane.rsand is independent of the partition-budget and severity-clustering experiments.Validation
do_get, GetSchema IPC, typed/null results, deterministic ordering, errors/authentication, and old/new persisted-reader checks passed with independent result oracles. Successful Flight calls no longer produceInconsistentCardinality.git diff --checkand formatting check for the changed file passed after extraction. No full rebuild was repeated for this source-identical split.This PR has:
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.