Skip to content

fix(flight): supply the tenant label for query timing metrics - #116

Merged
VibeSWE merged 1 commit into
mainfrom
fix/flight-query-metric-labels
Nov 8, 2026
Merged

VibeSWE merged 1 commit into
mainfrom
fix/flight-query-metric-labels

Conversation

@VibeSWE

@VibeSWE VibeSWE commented Nov 8, 2026 •

Copy link
Copy Markdown

Description

Successful Arrow Flight do_get calls panic while recording query duration: QUERY_EXECUTE_TIME declares stream and tenant_id labels, while this handler supplies only the stream label. Clients receive a reset instead of the completed result.

Supply DEFAULT_TENANT as the second label. The handler already authorizes and executes with no tenant override, so this matches its execution context. The metric definition, query behavior, and Flight wire format are unchanged.

This PR is limited to two lines in src/handlers/airplane.rs and is independent of the partition-budget and severity-clustering experiments.

Validation

  • Exact production-source match with the isolated baseline-plus-metric-fix control built and exercised on a disposable Boat VM, with Rust 1.97.1, locked dependencies, default features, jemalloc, ordinary release profile, and real frontend assets.
  • Successful authenticated Flight do_get, GetSchema IPC, typed/null results, deterministic ordering, errors/authentication, and old/new persisted-reader checks passed with independent result oracles. Successful Flight calls no longer produce InconsistentCardinality.
  • The same fix also passed the combined campaign's multi-batch Flight checks, which independently decoded 4,194,304 rows. That campaign's broader optimizations and artifacts are excluded here.
  • git diff --check and formatting check for the changed file passed after extraction. No full rebuild was repeated for this source-identical split.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • kept the change focused on the confirmed Flight query failure.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@VibeSWE
VibeSWE merged commit 9f523bd into main Nov 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant