Repository navigation
SignatureRefining: Do not entirely give up when seeing tables - #9231
Merged
Merged
Conversation
stevenfontanella
approved these changes
Oct 7, 2026
Member
Author
|
On a large Dart testcase, I see that this pass refines around 10% of the total signature types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this pass would just not run if even a single table was
present. Instead, skip types in tables/element segments.
This is important for e.g. Dart, which so far has gotten no benefit
out of SignatureRefining, because they use a few tables.