Repository navigation
[DAE] Recompute callers in each iteration - #9235
Merged
Merged
Conversation
The set of callers was computed once, in the first iteration. But optimizing functions between iterations can create new direct calls, for example by turning a call_ref of a ref.func into a call. When the return type of the callee was later refined, these new callers were not refinalized, which left stale types. Recompute the callers in each iteration, together with the calls. This is cheap, as each caller appears at most once per callee in the scan results. Fixes WebAssembly#9233.
kripken
approved these changes
Oct 8, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
Thanks! And nice, this is indeed quite cheap to compute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of callers was computed once, in the first iteration. But optimizing functions between iterations can create new direct calls, for example by turning a
call_refof aref.funcinto acall. When the return type of the callee was later refined, these new callers were not refinalized, which left stale types.Recompute the callers in each iteration, together with the calls. This is cheap, as each caller appears at most once per callee in the scan results.
Fixes #9233.