Repository navigation
Attempt to type-check writers - #250
Open
WhyNotHugo wants to merge 3 commits into
Open
WhyNotHugo wants to merge 3 commits into
WhyNotHugo wants to merge 3 commits into
Conversation
WhyNotHugo
marked this pull request as draft
August 30, 2025 18:01
WhyNotHugo
force-pushed
the
writer-types
branch
from
October 9, 2026 23:40
dab3fdf to
2ba6c11
Compare
WhyNotHugo
marked this pull request as ready for review
October 9, 2026 23:41
These tests use a non-standard property which only exists on this barcode, but get_barcode returns a type-erased barcode type. This usage would not work with any other barcode type, so it's not ideal. Use the concrete barcode type instead.
Make writers generic, since both subclasses produce barcodes of different types. Trickle this to all affected interfaces, so that when using an ImageWriter, the return type is Image, rather than `Image | bytes`. This improves correctness downstream, since consumers now get the right type depending on the writer they're using. The actual API remains unchanged. Changes to tests/test_builds.py are because that test uses a property specific to Code128.
WhyNotHugo
force-pushed
the
writer-types
branch
from
October 9, 2026 23:43
2ba6c11 to
ad100ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is incomplete.