Repository navigation
Cache vcpkg dependencies in MSVC build - #426
Merged
Merged
Conversation
hpoettker
force-pushed
the
speed-up-msvc
branch
from
November 2, 2026 22:42
44aa604 to
6502788
Compare
Contributor
Author
|
The build is now successful as a sufficient number of MacOS runners is now available. And the build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I think it's good that #401 and #410 moved the Windows Visual Studio build from AppVeyor to GitHub Actions. It reduces complexity and lets the build also run on forks without an AppVeyor setup.
But with runtimes above 10 minutes for every run, the build is currently way too slow.
Proposal
I've added a caching step for the vcpkg binaries.
The image versions of the Windows runners are surprisingly diverse. So the cache takes a few runs to get warm. But on a cache hit the build runs in under two minutes: https://github.com/hpoettker/ReadStat/actions/runs/41507166556/job/125489304309
I've also replaced
ilammy/msvc-dev-cmd, which hasn't seen a commit in the last two years, withmicrosoft/setup-msbuild.Note
The build may fail as MacOS runners are currently in high demand. If it should fail due to that I'll trigger a rebuild with an empty amended commit at a later point.