Repository navigation
test(workflows): updateGuards write-path unit test + backlog release status - #196
Merged
Merged
Conversation
…items shipped - MockK tests: updateGuards persists the "type" discriminator for both guard kinds, and guards it writes are read back by validateTransition (400 key, not a deserialization error). Both fail against the pre-B4 write path. - backlog-overview: B2, B4-B7, H4-H6 were released in v1.0.22 (per git tags). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowTransitionGuardTestcover the write path ofWorkflowService.updateGuards(B4):type(REQUIRED_FIELD/ROLE_RESTRICTION) plus payload for both guard kindsupdateGuardsare read byvalidateTransition, which fails withworkflow.transitionFieldRequired(400) instead of a deserialization error (500)mapper.writeValueAsString(guards)both tests fail.docs/superpowers/backlog-overview.mdnow marks B2, B4, B5, B6, B7, H4, H5 and H6 as shipped in v1.0.22. Source:git tag --containson the merge commits of PRs fix(b6): unknown paths return 404 instead of 500 #170–fix(b5): SSO usable from the UI (link, proxy, callback, refresh token) #174, fix(h5): auth rate limit can no longer be bypassed via X-Forwarded-For #177–fix(h6): publish PostgreSQL on loopback only #179. v1.0.23 contained only maintenance/Dependabot work, so no backlog entries changed for it.No production code changes.
Test plan
./gradlew test(backend): 416 tests, 0 failures🤖 Generated with Claude Code