Repository navigation
Overhaul the page footer - #6741
Merged
Merged
Conversation
…SS into its own stylesheet
… regular dropdown
…e compact footer's own colors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing page footer looks quite dated and has a few design issues that we want to rectify:
Following the pattern of #6727 we have reused the principle of style options to introduce a new footer that ships as an opt-in feature while still offering the legacy view. We also moved the language selection into the footer because this takes up some space in the header and our language detection works reliably, thus this is barely ever useful. On mobile it stays an easy to reach option in the menu because scrolling down long pages is awkward in this device class.
Closes #6240
Fully Backwards Compatible
As mentioned above, the legacy page footer (once again dubbed “classic”) remains available and all previous styles default to this version. We continue to ship the same exact HTML and CSS that is required for existing styles in order not to break the backwards compatibility. The new footer uses the same switch mechanic as the page header, loading a different template and stylesheet.
Color Scheme Switcher
The new layout finally allows us to integrate the color scheme switcher properly without breaking existing styles. This feature is now available to guests too, thus they are no longer limited to the “system” preset. The availability of the color scheme switcher depends on the active style.
Previews
Disclaimer: The screenshots are from an active development version and are subject to change.
The footer with all available options. The language selection is available for guests only but is also used for the language switch in the developer tools. The style switcher is controlled by the existing option.