Skip to content

Improve the style protection and offer a rollback for customized colors - #6752

Merged
dtdesign merged 3 commits into
6.3from
63-protected-styles
Oct 25, 2026
Merged

dtdesign merged 3 commits into
6.3from
63-protected-styles

Conversation

@dtdesign

Copy link
Copy Markdown
Member

The concept of protecting styles was meant to provide better updates but it was too tempting for users to drop the protection. The problem is that this never solves a problem and instead creates new ones because a then customized style has a high chance of being bricked the moment an update lands.

Another short-coming is the customization of colors which means that once a value has been altered, it is not possible to recover its value. Reinstalling the style would wipe other changes too which makes it difficult to experiment without having to maintain dozens of copies.

This PR changes the situation in two ways:

  1. Styles imported through packages will remain protected at all times, ensuring proper update support. Creating a copy is the only way to escape this, creating a style that is no longer attached to a package.
  2. Newly imported styles as well as updated styles will now track the authored value for colors, offering a button to restore an individual value if the user wants to.

@dtdesign
dtdesign marked this pull request as ready for review October 25, 2026 13:40
@dtdesign dtdesign moved this to Minor Task in WoltLab Suite 6.3 Oct 25, 2026
@dtdesign
dtdesign merged commit c65ece7 into 6.3 Oct 25, 2026
10 checks passed
@dtdesign
dtdesign deleted the 63-protected-styles branch October 25, 2026 13:43
@github-project-automation github-project-automation Bot moved this from Minor Task to Done in WoltLab Suite 6.3 Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant