Repository navigation
Improve the style protection and offer a rollback for customized colors - #6752
Merged
Merged
Conversation
…side and leave copies unprotected
…t that updates the style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concept of protecting styles was meant to provide better updates but it was too tempting for users to drop the protection. The problem is that this never solves a problem and instead creates new ones because a then customized style has a high chance of being bricked the moment an update lands.
Another short-coming is the customization of colors which means that once a value has been altered, it is not possible to recover its value. Reinstalling the style would wipe other changes too which makes it difficult to experiment without having to maintain dozens of copies.
This PR changes the situation in two ways: