Repository navigation
Upgrade/Install: Improve plugin and theme auto-update email subjects - #13761
Open
rootzero00 wants to merge 3 commits into
Open
rootzero00 wants to merge 3 commits into
rootzero00 wants to merge 3 commits into
Conversation
Use item names for single updates and counts for multiple updates in plugin and theme auto-update email subjects. Decode entities, scrub invalid UTF-8, and truncate long names safely. Add coverage for success, failure, mixed updates, plurals, entities, Unicode handling, and final mail subjects. Props #66075.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Merge current trunk while preserving upstream updater tests and PHPStan baselines. Fall back to singular counts for blank names, retain legacy combined plugin/theme subjects, and truncate names at 35 Unicode code points with an appended ellipsis. Preserve UTF-8 scrubbing and entity decoding, including literal ampersand suffixes. Add regression coverage for blank names, combined subjects, and truncation boundaries. Validation: 139 updater tests / 227 assertions passed in each of single-site and multisite; PHPStan 2.3.2 level 5, coding standards, syntax, and diff checks passed. AI assistance: ChatGPT/Codex. Trac: https://core.trac.wordpress.org/ticket/66075
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves plugin and theme auto-update email subjects by naming the
individual plugin or theme when there is a single update, and using
counts when multiple items are updated or fail to update.
The change also prepares item names for use in mail subjects by
decoding entities, scrubbing invalid UTF-8, and safely truncating
long names.
PHPUnit coverage is included for success, failure, and mixed-update
subjects; single-item names and multiple-item counts; entity decoding;
Unicode handling; truncation; and final mail subjects.
Trac ticket: https://core.trac.wordpress.org/ticket/66075
Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Sol
Used for: Investigation support, contribution workflow and validation
planning, review assistance, and drafting. The implementation, tests,
repository state, and submitted contribution were reviewed and
validated by me.
This Pull Request is for code review only. Please keep all other
discussion in the Trac ticket. Do not merge this Pull Request. See
GitHub Pull Requests for Code Review
in the Core Handbook for more details.