Skip to content

Help/About: Note why the About page version stays hardcoded. - #14846

Open
trascaandrei wants to merge 1 commit into
WordPress:trunkfrom
trascaandrei:help-about-hardcoded-version-note
Open

trascaandrei wants to merge 1 commit into
WordPress:trunkfrom
trascaandrei:help-about-hardcoded-version-note

Conversation

@trascaandrei

Copy link
Copy Markdown

$display_major_version in about.php is the release the page describes. This adds a comment so that value is not replaced with the running version. It should change in the same commit as the copy, images, and documentation links. Prerelease and minor versions keep it: minor release notes are linked from the maintenance section, and the field guide and feature page are published for the major.

Trac ticket: https://core.trac.wordpress.org/ticket/66378

Use of AI Tools

AI assistance: Yes
Tool(s): Cursor
Model(s): Grok 4.7
Used for: Drafting the comment wording and this pull request text. The change was reviewed before it was submitted.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

The value is the release the page describes, so it should change with the copy, images, and documentation links rather than follow prerelease or minor versions.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props trascaandrei.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant