Skip to content

Comments: Do not link to posts of an unregistered post type on the Comments screen - #14852

Open
mpeshev wants to merge 1 commit into
WordPress:trunkfrom
mpeshev:36058-comments-list-missing-post-type
Open

mpeshev wants to merge 1 commit into
WordPress:trunkfrom
mpeshev:36058-comments-list-missing-post-type

Conversation

@mpeshev

@mpeshev mpeshev commented Oct 25, 2026

Copy link
Copy Markdown

When a comment belongs to a post whose post type is no longer registered (for example after deactivating the plugin that registered it), the Comments screen printed an edit link with an empty URL, read the view_item label of a null post type object (two PHP warnings per row and an empty link), and linked the comment date to a permalink that cannot work.

In the direction of 36058.diff on the ticket, this shows the post title and the comment date as plain text in that case. The date column now checks that the post type exists, so it also stops linking comments whose post no longer exists (comment:5).

Trac ticket: https://core.trac.wordpress.org/ticket/36058

Testing

  • Two new tests in tests/phpunit/tests/admin/wpCommentsListTable.php fail on trunk (Attempt to read property "labels" on null, and a linked date) and pass with the patch.
  • vendor/bin/phpunit --group comment passes (756 tests).

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: reproducing the issue, drafting the fix and tests, and running them. I reviewed every line.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

…mments screen.

When a comment belongs to a post whose post type is no longer registered, for example after deactivating the plugin that registered it, the Comments screen printed an edit link with an empty URL, read the `view_item` label of a null post type object (raising PHP warnings and printing an empty link), and linked the comment date to a permalink that cannot work.

Show the post title and the comment date as plain text in that case. The date is also no longer linked when the comment's post does not exist.

See #36058.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nofearinc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant