Repository navigation
Conversation
…mments screen. When a comment belongs to a post whose post type is no longer registered, for example after deactivating the plugin that registered it, the Comments screen printed an edit link with an empty URL, read the `view_item` label of a null post type object (raising PHP warnings and printing an empty link), and linked the comment date to a permalink that cannot work. Show the post title and the comment date as plain text in that case. The date is also no longer linked when the comment's post does not exist. See #36058. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
When a comment belongs to a post whose post type is no longer registered (for example after deactivating the plugin that registered it), the Comments screen printed an edit link with an empty URL, read the
view_itemlabel of a null post type object (two PHP warnings per row and an empty link), and linked the comment date to a permalink that cannot work.In the direction of 36058.diff on the ticket, this shows the post title and the comment date as plain text in that case. The date column now checks that the post type exists, so it also stops linking comments whose post no longer exists (comment:5).
Trac ticket: https://core.trac.wordpress.org/ticket/36058
Testing
tests/phpunit/tests/admin/wpCommentsListTable.phpfail on trunk (Attempt to read property "labels" on null, and a linked date) and pass with the patch.vendor/bin/phpunit --group commentpasses (756 tests).Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: reproducing the issue, drafting the fix and tests, and running them. I reviewed every line.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code