[shail-mehta]

Part of: #64895

What

Replaces the remaining assertNotEquals() calls in tests/phpunit/tests/adminbar.php with assertNotSame() for profile URL comparisons.

Updated methods:

• test_admin_bar_contains_correct_links_for_users_with_no_role(): assertNotEquals → assertNotSame
• test_admin_bar_contains_correct_links_for_users_with_no_role_on_network(): assertNotEquals → assertNotSame

Why

These comparisons are URL strings (get_admin_url() / user_admin_url() vs admin_url()), so assertNotSame() is appropriate. Same approach as [r63632] / [r64079].

How

• Convert the two profile URL inequality checks from assertNotEquals() to assertNotSame()
• Leave other assertions in the file unchanged

Testing instructions

1. Start the local WordPress develop environment.
2. Run: npm run test:php -- --filter Tests_AdminBar
3. For the multisite cases: npm run test:php -- --group ms-required --filter Tests_AdminBar

Use of AI tools

Cursor

[Copilot]

🟢 Approval recommended

Both comparisons use URL strings, so strict inequality preserves the intended checks without identified correctness issues.

No open issues 🎉

What changed in this PR

This PR updates two admin bar tests to use strict inequality assertions for profile URL strings. No production code changes are included.

Changes:

• Replace two assertNotEquals() calls with assertNotSame().
• Leave all other assertions unchanged.

File	Description
tests/​phpunit/​tests/​adminbar.php	Use strict inequality for two profile URL comparisons.

_{Review effort: Balanced}

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[Copilot]

🟢 Approval recommended

Both comparisons use URL strings, so the replacements preserve the intended checks without identified correctness issues.

No open issues 🎉

_{Review effort: Balanced}

[lancewillett]

The changed comparisons use profile URL strings, and the surrounding assertions still verify the admin bar destinations. The multisite run exercised the changed cases.

Unit-tests audit completed. Combined randomized runs passed: single-site 497 tests / 1,609 assertions; multisite 521 tests / 1,694 assertions, with one skip in each run. PHPCS and CI passed. Copilot has no open findings.

_{AI review · gpt-6}

[lancewillett]

PR #14853 landed in https://core.trac.wordpress.org/changeset/64781