On This Day dashboard widget follow up by peterwilsoncc · Pull Request #14866 · WordPress/wordpress-develop

peterwilsoncc · 2026-10-25T23:44:32Z

Makes the following changes to the On This Day dashboard widget:

Displays up to 100 posts
Sets the feature as opt-in, per my comment on the ticket regarding the potential for these features to be upsetting.
Adds a wp prefix in a bunch of places (mainly IDs and classes)
tidy up the test suite a bit to include assertion messages, remove remove_filter where it's not needed, use the get_echo() helper.

Trac ticket: https://core.trac.wordpress.org/ticket/65116

Use of AI Tools

Claude Opus 5.5 Medium
Not used for source changes
Used for the following in the test suite:
- Clean up to use get_echo() helper
- Adding unique message parameters to tests with multiple assertions
- drafting the tests for opt-in, opt-out and pre choice tests
- drafting each test summary

github-actions · 2026-10-25T23:47:51Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

peterwilsoncc · 2026-10-26T00:01:04Z

+			$( '#wp-on-this-day-posts-form form button' ).on( 'click.postboxes', function( event ) {
+				event.preventDefault();
+				var enabled = '1' === $( this ).prop( 'value' );
+
+				postboxes.setOnThisDayDisplay( enabled );
+				postboxes.save_on_this_day_display( enabled );
+			} );


Is this better in another location?

github-actions · 2026-10-26T01:50:58Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @joen.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, westonruter, fcoveram, annezazu, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

@propsbot add <username> to give props to a GitHub user. Requires write access.
@propsbot remove <username> to leave a user out of the props. Requires write access.
@propsbot refresh to refresh this list. Adding the props-bot label works too.

Co-authored-by: Weston Ruter <westonruter@gmail.com>

peterwilsoncc · 2026-10-26T03:14:25Z

@propsbot add Joen

Co-authored-by: Weston Ruter <westonruter@gmail.com>

…ss ternary.

fcoveram · 2026-10-26T14:23:44Z

It works as expected. I just noticed two things

Spacing at the bottom of the widget

There is an extra space at the bottom of the widget that's unnecessary. I that that removing it with a last-child property is sufficient.

Zebra stripping in different heights

The white and grey rows have different sizes (respectively, red and green in the screenshot). I see in Chrome's inspector there is a bottom margin of 6px that pushes the white rows higher.

As suggested in this comment in the trac ticket, it would be great to have the filter options.

annezazu · 2026-10-26T17:00:55Z

This seems to be working well. I don't feel strongly around opt in vs opt out and I also think just being able to opt out at all is what's needed. Thinking about my own use case, I have a number of quite upsetting posts on my blog and none are tagged/categorized in a way where I could easily track them down, without needing to go back through all of them to tag them with the same thing (sounds awful to do). I do like the idea of hiding individual posts though as that feels like a more likely use case to start.

I found one minor inconsistency to clean up where if you opt in then opt out, there's an extra line in the widget that doesn't appear on a fresh install.

Opting in with this PR:

Post opt out with this PR:

View of 7.1:

See the extra line at the bottom

…titled_excerpts

…ered_after_comments_are_deleted

peterwilsoncc · 2026-10-26T20:44:14Z

Night brain figured out the cause of the extra line, I'll push some commits to fix it over the next few days.

At present the opt-in form only displays on days which feature OTD posts. This is so turning the feature on results in a display. I can modify it to display placeholder text when a user toggle the display (and only when they toggle). Is that useful?

peterwilsoncc · 2026-10-26T20:45:20Z

...over the next few days.

Hours... not days. I guess I am still waking up.

audrasjb · 2026-10-26T21:39:40Z

This looks good to me, event if I don't have a strong opinion about he opt-in/opt-out feature. Yes I read your previous comment before, but I'm not that convinced that we need to complexify the interface and the technical implementation that much. But I don't have strong feelings against the proposal, too 🤷

peterwilsoncc · 2026-10-26T23:25:19Z

I've pushed some changes to fix the following:

extra space at end of widget
modified the list item styles to avoid the spacing (caused by an interaction with common.css) in the zebra striping

peterwilsoncc · 2026-10-26T23:27:06Z

As suggested in this comment in the trac ticket, it would be great to have the filter options.

@fcoveram Agreed but I think that can be a stretch goal post beta 2. I think it will add a lot more complexity to the widget.

peterwilsoncc added 3 commits October 26, 2026 08:11

Increase query limit, per @m.

2930fd1

OTD: Markup form.

c3e69fe

On This Day opt-in.

794f554

peterwilsoncc added 3 commits October 26, 2026 10:48

No need for setting to be stored on object.

b406247

Did not mean to delete this.

7fae9f7

Prefix all the things.

0fea482

peterwilsoncc commented Oct 26, 2026

View reviewed changes

peterwilsoncc added 11 commits October 26, 2026 11:03

missing comma.

bba27d3

Update test for number of posts queried by OTD widget.

7f5b550

Remove uneeded teardown.

4774770

Use get_echo helper for test suite.

132390e

Add messages to tests with multiple assertions.

08c4372

Clarify OTD tests are for OTD.

1948059

Ensure OTD posts are hidden before opt in.

f0420de

Do not render form after opt-in or -out.

e0836e0

Test nothing displayed after opt-out. HTML renders for list.

6a87b41

Ensure list displays after user has opted in.

2a2f6db

Add summary to OTD tests.

f1712ba

peterwilsoncc marked this pull request as ready for review October 26, 2026 01:50

peterwilsoncc requested review from audrasjb and joedolson October 26, 2026 01:58

westonruter requested changes Oct 26, 2026

View reviewed changes

i18n fixes.

d604837

Co-authored-by: Weston Ruter <westonruter@gmail.com>

This comment has been minimized.

Sign in to view

Type fixes.

0f3f610

Co-authored-by: Weston Ruter <westonruter@gmail.com>

peterwilsoncc and others added 2 commits October 26, 2026 14:16

Trolling?

b5174d2

Smarten up toggling display.

32f28b2

Co-authored-by: Weston Ruter <westonruter@gmail.com>

peterwilsoncc added 2 commits October 26, 2026 14:50

Comment: explain what else means.

c9fd3e8

Use variable to determine whether to display the form, remove pointle…

ec27f55

…ss ternary.

peterwilsoncc requested a review from westonruter October 26, 2026 03:54

Typo: Filter -> filtered.

b58426e

westonruter added 5 commits October 26, 2026 13:20

Merge branch 'trunk' into do/65116-otd-follow-up

639820b

Use mock action and move method to closure

014c605

Fix static analysis in test_otd_renders_posts_from_all_authors_and_un…

2decea5

…titled_excerpts

Improve static analysis in test_recent_comments_widget_remains_regist…

f02d84e

…ered_after_comments_are_deleted

Improve static analysis of get_inline_styles_by_id test helper

22692a0

peterwilsoncc added 4 commits October 27, 2026 10:02

Fix styles: extra line at bottom of widget.

a622593

Modify LI styles to account for those in common.css.

a7ce5fa

Account for hide-if-no-js if there is no JS.

fbbfa23

Merge branch 'trunk' into do/65116-otd-follow-up

b3fc866

peterwilsoncc added 2 commits October 27, 2026 10:47

Pre-flight filter for OTD activity.

2dad3b6

Test for hidden class rather than display style.

d990e65

Conversation

peterwilsoncc commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use of AI Tools

Uh oh!

github-actions Bot commented Oct 25, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

peterwilsoncc Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

peterwilsoncc commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcoveram commented Oct 26, 2026

Spacing at the bottom of the widget

Zebra stripping in different heights

Uh oh!

annezazu commented Oct 26, 2026

Uh oh!

peterwilsoncc commented Oct 26, 2026

Uh oh!

peterwilsoncc commented Oct 26, 2026

Uh oh!

audrasjb commented Oct 26, 2026

Uh oh!

peterwilsoncc commented Oct 26, 2026

Uh oh!

peterwilsoncc commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

peterwilsoncc commented Oct 25, 2026 •

edited

Loading

github-actions Bot commented Oct 26, 2026 •

edited

Loading

peterwilsoncc commented Oct 26, 2026 •

edited

Loading