Skip to content

Editor: Preserve list structure when switching from Text to Visual mode - #14883

Open
Sourav61 wants to merge 1 commit into
WordPress:trunkfrom
Sourav61:fix/66379-classic-editor-list-bookmarks
Open

Sourav61 wants to merge 1 commit into
WordPress:trunkfrom
Sourav61:fix/66379-classic-editor-list-bookmarks

Conversation

@Sourav61

Copy link
Copy Markdown

Description

Fixes https://core.trac.wordpress.org/ticket/66379.

Switching from Text to Visual mode in the Classic Editor with the cursor positioned immediately after a closing </li> tag causes TinyMCE to restructure the list unexpectedly.

This happens because the editor inserts a temporary selection bookmark directly inside the list, creating an invalid HTML structure. TinyMCE then normalizes the markup by nesting preceding list items inside an additional <li style="list-style-type: none;"> element, resulting in unwanted indentation and changes to the original list.

Changes

  • Adjusted both selection endpoints to ensure bookmarks positioned after </li> tags or their trailing whitespace are inserted inside the preceding list item.
  • Prevented TinyMCE from receiving invalid list structures during editor switching.
  • Preserved the original list markup and cursor selection when switching between Text and Visual modes.

Testing

  • Added regression tests covering ordered, unordered, and nested lists, whitespace variations, uppercase tags, list item attributes, and selection ranges.
  • Confirmed all 41 assertions pass with the fix, while 27 assertions fail with the original implementation.
  • Verified the behavior with WordPress's TinyMCE plugin and wpautop enabled.
  • Confirmed JavaScript lint checks pass.

Use of AI Tools

AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-6
Used for: Assistance with investigation and implementation suggestions. Final implementation and regression tests were reviewed and verified manually.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See [GitHub Pull Requests for Code Review](https://make.wordpress.org/core/handbook/contribute/git/github-pull-requests-for-code-review/) in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sourav08.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant