Repository navigation
REST API: Add unit tests for custom post type controllers in the comments read permission check - #14892
Open
irozum wants to merge 1 commit into
Conversation
…ents read permission check.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WP_REST_Comments_Controller::check_read_post_permission()using a post type's custom REST controller. Follow-up to [46272], which made the comments controller askWP_Post_Type::get_rest_controller()for the controller.src/files are touched and no production behaviour is added.Cases covered
GET /wp/v2/comments?post=<id>returnsrest_cannot_read_post(401) for an anonymous user when the custom controller'scheck_read_permission()denies access.GET /wp/v2/comments/<id>returnsrest_cannot_read(401) in the same situation.WP_REST_Posts_Controller(hereWP_REST_Post_Types_Controller), the comments controller falls back to a posts controller instead of calling a missing method.Why these cases
The existing tests only check
get_rest_controller()itself. Nothing checked that the comments endpoints actually defer to a custom controller for read access, or that they fall back safely.Verification
WP_REST_Posts_Controller.check_read_permission()result is ignored, and the fallback test also fails if theinstanceoffallback is removed.Trac ticket: https://core.trac.wordpress.org/ticket/40383
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Planning the test cases and writing the tests.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code