Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/50675
Summary
What: Adds PHPUnit coverage for
WP_REST_Attachments_Controller::edit_media_item()copying data from the original attachment to the edited one. This is a test-only change; it touches nosrc/files and adds no production behaviour.Context: Follow-up to [48510], which added this behaviour. Nothing in trunk covers the fallback path: the existing
test_edit_image_updates_attachment_fields()(#64035) only passes every field explicitly in the request.Cases covered:
_wp_attachment_image_altmeta row is created on the new attachment.titleandalt_text: those win, while the omitted caption and description are still inherited (mixed precedence).Verification: Each test was confirmed to fail when the matching code in
edit_media_item()was temporarily broken (fallbacks removed, alt fallback removed, empty-alt guard removed,??=changed to=, alt ternary swapped), then restored.Out of scope: The EXIF
image_metamerge from the same changeset; it depends on GD/Imagick EXIF output and could be a follow-up.Use of AI Tools
This PR was prepared with Claude Code (Claude Sonnet 5.5), which wrote the tests and ran the verification above.
This pull request is for code review only. Please keep all discussion in the Trac ticket.