Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PclZiphandles zero-byte entries. On PHP 8,fread( $fd, 0 )throws aValueError, which@doesn't suppress.src/and adds no production behaviour.class-pclzip.phpwithout tests.Tests added
Tests_Filesystem_UnzipFilePclzip::test_should_extract_empty_files()runs_unzip_file_pclzip()on the existingarchive.zipfixture, which has two zero-byte stored files. It asserts both are extracted and empty. This covers theprivExtractFileAsString()guard. The existing tests only checked filter calls.Tests_Filesystem_PclZip::test_extract_in_output_should_output_empty_file()extracts an empty entry withPCLZIP_OPT_EXTRACT_IN_OUTPUT. It asserts no output and a correct entry. This covers theprivExtractFileInOutput()guard, which nothing exercised before.Tests_Filesystem_PclZip::test_create_should_add_empty_file()creates an archive from an empty file (withPCLZIP_OPT_TEMP_FILE_OFF, to reach the in-memory branch) and reads it back. This covers theprivAddFile()guard from #54036.Why these cases
Each test fails with
ValueError: fread(): Argument #2 ($length) must be greater than 0when its guard is reverted (> 0changed to>= 0), and passes with the guard restored. On PHP 7.4fread()only warns, so the behavioural assertions hold there too.Trac ticket: https://core.trac.wordpress.org/ticket/52018
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Drafting the tests and this description, and running the mutation checks and coding-standards checks.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code