Skip to content

Tests: Make XML-RPC data providers static #14972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robelsust wants to merge 4 commits into from
Closed

Tests: Make XML-RPC data providers static #14972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4c9a2a
Tests: Make XML-RPC data providers static.
robelsust Oct 27, 2026
3186599
Merge branch 'trunk' into feature/66211-xmlrpc-static-data-providers
robelsust Oct 27, 2026
5e917f8
Tests: Add array return type to data_comments_observe_post_permission…
robelsust Oct 27, 2026
9166522
Merge branch 'trunk' into feature/66211-xmlrpc-static-data-providers
robelsust Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/phpunit/tests/xmlrpc/demo/addTwoNumbers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function test_add_two_numbers_with_valid_integers( $a, $b, $expected ) {
*
* @return array<string, int[]>
*/
public function data_valid_integers(): array {
public static function data_valid_integers(): array {
return array(
'two positive integers' => array( 3, 5, 8 ),
'positive and negative integer' => array( 10, -3, 7 ),
Expand Down Expand Up @@ -68,7 +68,7 @@ public function test_add_two_numbers_with_invalid_arguments( $a, $b, $message )
*
* @return array<string, array<mixed>>
*/
public function data_invalid_arguments(): array {
public static function data_invalid_arguments(): array {
return array(
'first argument is string' => array( 'abc', 5, 'Should fail when first argument is a string.' ),
'second argument is string' => array( 3, 'abc', 'Should fail when second argument is a string.' ),
Expand Down Expand Up @@ -148,7 +148,7 @@ public function test_add_two_numbers_with_too_many_arguments( $args, $message )
*
* @return array<string, array<mixed>>
*/
public function data_too_many_arguments(): array {
public static function data_too_many_arguments(): array {
return array(
'three arguments' => array( array( 3, 5, 100 ), 'Should fail with three arguments.' ),
'four arguments' => array( array( 10, 20, 30, 40 ), 'Should fail with four arguments.' ),
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/xmlrpc/wp/newComment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ public function test_comments_observe_post_permissions( $post_key, $username, $e
* @type string Optional. Allow anonymous comment callback. Default __return_false.
* }
*/
public function data_comments_observe_post_permissions() {
public static function data_comments_observe_post_permissions(): array {
return array(
// 0: Post author, password protected public post.
array(
Expand Down
10 changes: 5 additions & 5 deletions tests/phpunit/tests/xmlrpc/wp/uploadFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public function test_insufficient_arguments_should_return_error( array $args ) {
*
* @return array<non-falsy-string, array{args: list<mixed>}>
*/
public function data_insufficient_arguments(): array {
public static function data_insufficient_arguments(): array {
return array(
'no arguments' => array(
'args' => array(),
Expand Down Expand Up @@ -162,7 +162,7 @@ public function test_attachment_data_without_name_should_return_error( array $da
*
* @return array<non-falsy-string, array{data: array<string, mixed>}>
*/
public function data_attachment_data_without_name(): array {
public static function data_attachment_data_without_name(): array {
return array(
'empty struct' => array(
'data' => array(),
Expand Down Expand Up @@ -221,7 +221,7 @@ public function test_attachment_data_with_unusable_name_should_return_error( str
*
* @return array<non-falsy-string, array{name: string}>
*/
public function data_attachment_data_with_unusable_name(): array {
public static function data_attachment_data_with_unusable_name(): array {
return array(
'empty name' => array(
'name' => '',
Expand Down Expand Up @@ -277,7 +277,7 @@ public function test_attachment_data_with_invalid_members_should_return_error( a
*
* @return array<non-falsy-string, array{data: array<string, mixed>}>
*/
public function data_attachment_data_with_invalid_members(): array {
public static function data_attachment_data_with_invalid_members(): array {
return array(
'non-string bits' => array(
'data' => array(
Expand Down Expand Up @@ -324,7 +324,7 @@ public function test_attachment_data_with_optional_members_omitted_should_be_acc
*
* @return array<non-falsy-string, array{data: array<string, mixed>}>
*/
public function data_attachment_data_with_optional_members_omitted(): array {
public static function data_attachment_data_with_optional_members_omitted(): array {
return array(
'missing type' => array(
'data' => array(
Expand Down
Loading