Skip to content

Tests: Unregister custom taxonomies in wpSetObjectTerms.php - #15090

Closed
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-term-wpsetobjectterms
Closed

rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-term-wpsetobjectterms

Conversation

@rejaulalomkhan

Copy link
Copy Markdown

Description

This PR unregisters custom taxonomies in tests/phpunit/tests/term/wpSetObjectTerms.php. Specifically:

  • Adds tear_down() unregistering wptests_tax.
  • Unregisters dynamically generated taxonomies ($non_hier and $hier) in test_set_object_terms().

Preventing test isolation leaks ensures that custom taxonomies registered during tests do not bleed into subsequent test suites.

Follow-up to #65893.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Use of AI Tools

  • Tool: Google Antigravity
  • Model: Gemini 2.5 Flash
  • Role: Test isolation leak analysis and patch generation.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@lancewillett

Copy link
Copy Markdown
Member

The added cleanup for wptests_tax repeats the Core test harness’s registry reset before each test. These registrations do not opt out of that reset, and no existing consumer is shown to fail before it. Closing this cleanup-only proposal as redundant; the existing behavioral tests remain unchanged.

The inherited reset runs in WP_UnitTestCase_Base::set_up().

Thanks for working on test isolation. We can reopen this if an existing test or fixture fails without the cleanup and passes with it under the same environment and order.

AI review · gpt-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants