Skip to content

Tests: Unregister custom post type in getPostTypeLabels.php - #15095

Open
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-post-getposttypelabels
Open

rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-post-getposttypelabels

Conversation

@rejaulalomkhan

Copy link
Copy Markdown

Description

In tests/phpunit/tests/post/getPostTypeLabels.php, register_post_type() is used across several test methods (test_labels_should_be_added_when_registering_a_post_type, test_label_should_be_derived_from_labels_when_registering_a_post_type, and test_should_fall_back_on_defaults_when_filtered_labels_do_not_contain_the_keys) to register a custom post type 'foo'.

While the tests attempt to unregister it inline, any assertion failure before reaching unregister_post_type() leaves 'foo' registered in the global $wp_post_types array, leaking state into subsequent test runs.

This PR adds a tear_down() method to Tests_Post_GetPostTypeLabels to reliably unregister 'foo' via unregister_post_type(), ensuring complete test isolation.

Trac ticket: https://core.trac.wordpress.org/ticket/65893


This pull request modifies test files only.

Summary of Changes

  • Added tear_down() method to Tests_Post_GetPostTypeLabels in tests/phpunit/tests/post/getPostTypeLabels.php unregistering 'foo'.

Test Coverage

  • Verified locally via vendor/bin/phpunit --filter Tests_Post_GetPostTypeLabels (9 tests, 12 assertions: all passed).
  • Ran PHPCS via vendor/bin/phpcs tests/phpunit/tests/post/getPostTypeLabels.php (0 errors, 0 warnings).

Use of AI Tools

  • Tool: Antigravity
  • Model: Gemini 2.5 Pro
  • Scope: Identifying test isolation leaks in getPostTypeLabels.php and drafting teardown cleanup.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants