[rejaulalomkhan]

Description

In Tests_Query (tests/phpunit/tests/query.php), tests register a custom post type (guide) and custom taxonomies (wptests_tax, test_tax_cat, tax1, tax2) without unregistering them in tear_down().

This leaks registered post types and taxonomies into the global registries, causing test pollution for other test classes running in the same process.

This PR adds a tear_down() method to Tests_Query to unregister guide, wptests_tax, test_tax_cat, tax1, and tax2.

Testing Instructions

1. Run vendor/bin/phpunit tests/phpunit/tests/query.php -> PASS (40 tests, 104 assertions).
2. Run vendor/bin/phpcs tests/phpunit/tests/query.php -> PASS (0 errors, 0 warnings).

Trac ticket: https://core.trac.wordpress.org/ticket/65893

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Use of AI Tools

• Tool: Antigravity
• Model: Gemini 2.5 Pro
• Role: Assisted in identifying unregistered custom post types and taxonomies in test teardown, formatting the patch, and generating PR documentation.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[huzaifaalmesbah]

Thanks for working on test isolation, @rejaulalomkhan!

I reviewed tests/phpunit/tests/query.php and verified that all 5 custom entities registered across the test methods (guide CPT, along with wptests_tax, test_tax_cat, tax1, and tax2 taxonomies) are now accounted for in tear_down(). This prevents rewrite and schema leaks into subsequent tests.

Verified locally on both single-site and multisite suites. LGTM!

_{AI Review: Gemini 3.8 Flash}

[lancewillett]

The added cleanup for guide, wptests_tax, test_tax_cat, tax1, tax2 repeats the Core test harness’s registry reset before each test. These registrations do not opt out of that reset, and no existing consumer is shown to fail before it. Closing this cleanup-only proposal as redundant; the existing behavioral tests remain unchanged.

The inherited reset runs in WP_UnitTestCase_Base::set_up().

Thanks for working on test isolation. We can reopen this if an existing test or fixture fails without the cleanup and passes with it under the same environment and order.

_{AI review · gpt-6}