Repository navigation
Tests: Unregister custom post types in getPostsByAuthorSql.php - #15097
Open
rejaulalomkhan wants to merge 1 commit into
Open
rejaulalomkhan wants to merge 1 commit into
rejaulalomkhan wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
mukeshpanchal27
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
tests/phpunit/tests/post/getPostsByAuthorSql.php,register_post_type()is used across tests (test_multiple_post_typesandtest_user_has_access_only_to_private_posts_for_certain_post_types) to register custom post types'foo','bar', and'baz'.While the tests call
_unregister_post_type()at the end of their methods, any assertion failure before that point leaves these custom post types registered in the global$wp_post_typesarray, leaking state into subsequent tests.This PR adds a dedicated
tear_down()method inTests_Post_GetPostsByAuthorSqlto unregister'foo','bar', and'baz'viaunregister_post_type(), ensuring complete test isolation.Trac ticket: https://core.trac.wordpress.org/ticket/65893
This pull request modifies test files only.
Summary of Changes
tear_down()method inTests_Post_GetPostsByAuthorSqlwithintests/phpunit/tests/post/getPostsByAuthorSql.phpunregistering'foo','bar', and'baz'.Test Coverage
vendor/bin/phpunit --filter Tests_Post_GetPostsByAuthorSql(16 tests, 21 assertions: all passed).vendor/bin/phpcs tests/phpunit/tests/post/getPostsByAuthorSql.php(0 errors, 0 warnings).Use of AI Tools
getPostsByAuthorSql.phpand drafting teardown cleanup.