[rejaulalomkhan]

Description

In tests/phpunit/tests/category/getAllCategoryIds.php, register_taxonomy() is used in test_get_all_category_ids() to register a custom taxonomy 'test_tax_cat'.

While the test calls _unregister_taxonomy() before the final assertion, an assertion failure before or at that point can leave 'test_tax_cat' registered in the global $wp_taxonomies array, leaking state into subsequent tests.

This PR adds a tear_down() method in Tests_Category_GetAllCategoryIds to reliably unregister 'test_tax_cat' via unregister_taxonomy(), ensuring complete test isolation.

Trac ticket: https://core.trac.wordpress.org/ticket/65893

---

This pull request modifies test files only.

Summary of Changes

• Added tear_down() method to Tests_Category_GetAllCategoryIds in tests/phpunit/tests/category/getAllCategoryIds.php unregistering 'test_tax_cat'.

Test Coverage

• Verified locally via vendor/bin/phpunit --filter Tests_Category_GetAllCategoryIds (1 test, 2 assertions: all passed).
• Ran PHPCS via vendor/bin/phpcs tests/phpunit/tests/category/getAllCategoryIds.php (0 errors, 0 warnings).

Use of AI Tools

• Tool: Antigravity
• Model: Gemini 2.5 Pro
• Scope: Identifying test isolation leaks in getAllCategoryIds.php and drafting teardown cleanup.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[lancewillett]

The added cleanup for test_tax_cat repeats the Core test harness’s registry reset before each test. These registrations do not opt out of that reset, and no existing consumer is shown to fail before it. Closing this cleanup-only proposal as redundant; the existing behavioral tests remain unchanged.

The inherited reset runs in WP_UnitTestCase_Base::set_up().

Thanks for working on test isolation. We can reopen this if an existing test or fixture fails without the cleanup and passes with it under the same environment and order.

_{AI review · gpt-6}