Skip to content

Tests: Unregister custom taxonomy in dateQuery.php - #15100

Open
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-query-datequery
Open

rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-query-datequery

Conversation

@rejaulalomkhan

Copy link
Copy Markdown

Description

In tests/phpunit/tests/query/dateQuery.php, register_taxonomy() is used in test_date_query_relation_or() to register a custom taxonomy 'foo'.

While the test calls _unregister_taxonomy() before the assertions, an assertion failure before or during that point can leave 'foo' registered in the global $wp_taxonomies array, leaking state into subsequent tests.

This PR adds a tear_down() method in Tests_Query_DateQuery to reliably unregister 'foo' via unregister_taxonomy(), ensuring complete test isolation.

Trac ticket: https://core.trac.wordpress.org/ticket/65893


This pull request modifies test files only.

Summary of Changes

  • Added tear_down() method to Tests_Query_DateQuery in tests/phpunit/tests/query/dateQuery.php unregistering 'foo'.

Test Coverage

  • Verified locally via vendor/bin/phpunit --filter Tests_Query_DateQuery (38 tests, 84 assertions: all passed).
  • Ran PHPCS via vendor/bin/phpcs tests/phpunit/tests/query/dateQuery.php (0 errors, 0 warnings).

Use of AI Tools

  • Tool: Antigravity
  • Model: Gemini 2.5 Pro
  • Scope: Identifying test isolation leaks in dateQuery.php and drafting teardown cleanup.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants