Repository navigation
Tests: Make data providers in tests/phpunit/tests/script-modules/ public and static - #15102
rejaulalomkhan wants to merge 1 commit into
Conversation
…lic and static See #66211.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the change making three PHPUnit data providers public static.
No open issues 🎉
What changed in this PR
This PR updates three data providers in the script-module PHPUnit tests to use public static declarations, aligning them with modern PHPUnit requirements without changing test data or assertions.
Changes:
- Makes the registration/enqueue provider and two fetch-priority providers static.
| File | Description |
|---|---|
tests/phpunit/tests/script-modules/wpScriptModules.php |
Adds static to three public data-provider methods. |
Review effort: Balanced
lancewillett
left a comment
lancewillett
left a comment
There was a problem hiding this comment.
The providers do not rely on test-instance state, and the datasets and assertions are unchanged. PHPCS passed on all changed files. The combined three-PR batch passed randomized single-site and multisite runs: 219 tests and 1,311 assertions per mode, seed 66211.
AI review · gpt-6
Declare ten data providers in the style-engine, script-module, and load tests as `public static` for compatibility with newer PHPUnit versions. Add explicit `array` return types to the five load providers. Preserve all datasets and assertions. Developed in: #15098, #15102, #15153 Props rejaulalomkhan, therssoftware, mukesh27. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@65027 602fd350-edb4-49c9-b593-d223f7449a82
|
PR #15102 landed in https://core.trac.wordpress.org/changeset/65027 |
Declare ten data providers in the style-engine, script-module, and load tests as `public static` for compatibility with newer PHPUnit versions. Add explicit `array` return types to the five load providers. Preserve all datasets and assertions. Developed in: WordPress/wordpress-develop#15098, WordPress/wordpress-develop#15102, WordPress/wordpress-develop#15153 Props rejaulalomkhan, therssoftware, mukesh27. See #66211. Built from https://develop.svn.wordpress.org/trunk@65027 git-svn-id: http://core.svn.wordpress.org/trunk@64177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Description
PHPUnit data providers that do not rely on test state or
$thisshould be declared aspublic staticto optimize test execution performance and comply with modern PHPUnit standards.Data providers updated in
tests/phpunit/tests/script-modules/wpScriptModules.php:data_test_register_and_enqueue_script_module()->public static functiondata_provider_fetchpriority_values()->public static functiondata_provider_to_test_fetchpriority_bumping()->public static functionTesting Instructions
vendor/bin/phpunit --filter test_comprehensive_methods tests/phpunit/tests/script-modules/wpScriptModules.php-> PASS (4 tests, 300 assertions).vendor/bin/phpunit --filter fetchpriority tests/phpunit/tests/script-modules/wpScriptModules.php-> PASS (12 tests, 79 assertions).vendor/bin/phpcs tests/phpunit/tests/script-modules/-> PASS (0 errors, 0 warnings).Trac ticket: https://core.trac.wordpress.org/ticket/66211
This Pull Request is for code review only. Please keep all other discussion to the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
Use of AI Tools
tests/phpunit/tests/script-modules/directory, converted data providers topublic static, and verified via PHPUnit/PHPCS. All changes inspected and verified locally before submission.