Skip to content

Tests: Unregister unregistered_pt in wpRegisterCoreUsersAbility.php - #15109

Closed
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-abilities-users-ability
Closed

rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-abilities-users-ability

Conversation

@rejaulalomkhan

Copy link
Copy Markdown
Member

Description

In tests/phpunit/tests/abilities-api/wpRegisterCoreUsersAbility.php, custom post types 'not_viewable_pt', 'public_pt', and 'private_pt' are properly unregistered in tear_down(). However, the test method test_user_can_read_user_not_viewable_post_type registers an additional custom post type 'unregistered_pt' without cleaning it up in tear_down().

If an assertion or error occurs during this test, the 'unregistered_pt' post type remains registered in the global $wp_post_types array, causing state pollution for subsequent tests.

This PR adds unregister_post_type( 'unregistered_pt' ); to tear_down(), ensuring complete test isolation.

Trac ticket: https://core.trac.wordpress.org/ticket/65893


This pull request modifies test files only.

Summary of Changes

  • In tests/phpunit/tests/abilities-api/wpRegisterCoreUsersAbility.php, added unregister_post_type( 'unregistered_pt' ); to tear_down().

Test Coverage

  • Verified locally via vendor/bin/phpunit --filter Tests_Abilities_API_WpRegisterCoreUsersAbility (76 tests, 514 assertions: all passed).
  • Ran PHPCS via vendor/bin/phpcs tests/phpunit/tests/abilities-api/wpRegisterCoreUsersAbility.php (0 errors, 0 warnings).

Use of AI Tools

  • Tool: Antigravity
  • Model: Gemini 2.5 Pro
  • Scope: Identifying leaked custom post types and ensuring proper teardown cleanup for test isolation.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett

Copy link
Copy Markdown
Member

The added cleanup for unregistered_pt repeats the Core test harness’s registry reset before each test. These registrations do not opt out of that reset, and no existing consumer is shown to fail before it. Closing this cleanup-only proposal as redundant; the existing behavioral tests remain unchanged.

The inherited reset runs in WP_UnitTestCase_Base::set_up().

Thanks for working on test isolation. We can reopen this if an existing test or fixture fails without the cleanup and passes with it under the same environment and order.

AI review · gpt-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants