Repository navigation
Tests: Unregister unregistered_pt in wpRegisterCoreUsersAbility.php - #15109
rejaulalomkhan wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
The added cleanup for The inherited reset runs in Thanks for working on test isolation. We can reopen this if an existing test or fixture fails without the cleanup and passes with it under the same environment and order. AI review · |
Description
In
tests/phpunit/tests/abilities-api/wpRegisterCoreUsersAbility.php, custom post types'not_viewable_pt','public_pt', and'private_pt'are properly unregistered intear_down(). However, the test methodtest_user_can_read_user_not_viewable_post_typeregisters an additional custom post type'unregistered_pt'without cleaning it up intear_down().If an assertion or error occurs during this test, the
'unregistered_pt'post type remains registered in the global$wp_post_typesarray, causing state pollution for subsequent tests.This PR adds
unregister_post_type( 'unregistered_pt' );totear_down(), ensuring complete test isolation.Trac ticket: https://core.trac.wordpress.org/ticket/65893
This pull request modifies test files only.
Summary of Changes
tests/phpunit/tests/abilities-api/wpRegisterCoreUsersAbility.php, addedunregister_post_type( 'unregistered_pt' );totear_down().Test Coverage
vendor/bin/phpunit --filter Tests_Abilities_API_WpRegisterCoreUsersAbility(76 tests, 514 assertions: all passed).vendor/bin/phpcs tests/phpunit/tests/abilities-api/wpRegisterCoreUsersAbility.php(0 errors, 0 warnings).Use of AI Tools