Skip to content

Tests: Unregister custom post types in view-config.php - #15110

Open
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-view-config
Open

rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-view-config

Conversation

@rejaulalomkhan

Copy link
Copy Markdown

Description

In tests/phpunit/tests/view-config.php, custom post types 'summaries_cpt' (registered in test_default_form_groups_declare_summary) and 'view_config_cpt' (registered in test_view_list_uses_post_type_all_items_label) are used during tests.

While these tests attempt inline unregistration, any unexpected failure or assertion exception beforehand leaves the custom post types registered in the global $wp_post_types array, polluting global test state.

This PR adds unregister_post_type( 'summaries_cpt' ); and unregister_post_type( 'view_config_cpt' ); to tear_down() in Tests_View_Config_API, guaranteeing test isolation.

Trac ticket: https://core.trac.wordpress.org/ticket/65893


This pull request modifies test files only.

Summary of Changes

  • In tests/phpunit/tests/view-config.php, unregister 'summaries_cpt' and 'view_config_cpt' in tear_down().

Test Coverage

  • Verified locally via vendor/bin/phpunit --filter Tests_View_Config_API (21 tests, 59 assertions: all passed).
  • Ran PHPCS via vendor/bin/phpcs tests/phpunit/tests/view-config.php (0 errors, 0 warnings).

Use of AI Tools

  • Tool: Antigravity
  • Model: Gemini 2.5 Pro
  • Scope: Identifying leaked custom post types and ensuring proper teardown cleanup for test isolation.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants