Repository navigation
Tests: Add disclaimer for wp_kses_decode_entities() coverage - #15111
Closed
shail-mehta wants to merge 1 commit into
Closed
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for this documentation-only clarification of legacy decoding behavior and the recommended alternative for new code.
No open issues 🎉
What changed in this PR
Adds a documentation-only caveat to the wp_kses_decode_entities() tests introduced in #14665, clarifying that they preserve historical behavior rather than recommend the helper for new code.
Changes:
- Recommends
WP_HTML_Decoder::decode_attribute()for new code. - Explains that the legacy helper decodes numeric entities but leaves named entities unchanged.
- Changes no test logic or production code.
| File | Description |
|---|---|
tests/phpunit/tests/kses/wpKsesDecodeEntities.php |
Adds a file-level disclaimer describing legacy behavior and the preferred decoder. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Trac ticket: #65819
Follow-up to #14665.
Adds a disclaimer to the
wp_kses_decode_entities()tests.Why
Add a clear test caveat that this helper should not be used from new code, and to prefer
WP_HTML_Decoder::decode_attribute().How
In
tests/phpunit/tests/kses/wpKsesDecodeEntities.php:WP_HTML_Decoder::decode_attribute()Test-only; no production code changes. Deprecation / caller refactor left for a separate follow-up.
Testing Instructions
npm run test:php -- --filter Tests_Kses_wpKsesDecodeEntitiesnpm run test:php -- --filter Tests_Kses_wpKsesDecodeEntities -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_Kses_wpKsesDecodeEntities --order-by=randomnpm run test:php -- --group ksesUse of AI Tools