Repository navigation
Build/Test Tools: Include the WordPress version in upgrade and install test Slack notifications. - #15128
Build/Test Tools: Include the WordPress version in upgrade and install test Slack notifications.#15128lancewillett wants to merge 1 commit into
Conversation
…l test Slack notifications. The Upgrade Tests and Installation Tests workflows can be dispatched against any WordPress version, but the Slack notifications only named the workflow and branch. Telling which version failed meant opening the run. This adds an optional `version` input to the reusable Slack notifications workflow. When set, the version is appended to the workflow name in the payload, for example "Upgrade Tests (WordPress 5.1)". Both workflows now pass the version under test, falling back to their defaults of `latest` and `nightly`. Props jorbin. See #66401. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the changes adding the WordPress version under test to Slack notifications.
No open issues 🎉
What changed in this PR
Adds the WordPress version under test to Slack notifications for upgrade and installation workflows, using the existing workflow-name field.
Changes:
- Adds an optional version input to the shared Slack workflow, preserving existing messages when omitted.
- Passes the selected upgrade version, defaulting to
latest. - Passes the selected installation version, defaulting to
nightly.
| File | Description |
|---|---|
.github/workflows/upgrade-testing.yml |
Passes the upgrade target version to Slack notifications. |
.github/workflows/slack-notifications.yml |
Appends the optional WordPress version to the workflow name. |
.github/workflows/install-testing.yml |
Passes the installation version to Slack notifications. |
Review effort: Balanced
|
PR #15128 landed in https://core.trac.wordpress.org/changeset/65005 |
Include the requested WordPress version in Upgrade Tests and Installation Tests notifications, using the existing `workflow_name` payload field. Keep notifications unchanged for callers that omit the optional `version` input. Use `latest` as the default upgrade target and `nightly` as the default installation version. Developed in: #15128 Props jorbin, lucatume. Fixes #66401. git-svn-id: https://develop.svn.wordpress.org/trunk@65005 602fd350-edb4-49c9-b593-d223f7449a82
Include the requested WordPress version in Upgrade Tests and Installation Tests notifications, using the existing `workflow_name` payload field. Keep notifications unchanged for callers that omit the optional `version` input. Use `latest` as the default upgrade target and `nightly` as the default installation version. Developed in: WordPress/wordpress-develop#15128 Props jorbin, lucatume. Fixes #66401. Built from https://develop.svn.wordpress.org/trunk@65005 git-svn-id: http://core.svn.wordpress.org/trunk@64155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds the WordPress version under test to Slack notifications from the Upgrade Tests and Installation Tests workflows.
Before:
After:
Changes
slack-notifications.yml: new optionalversioninput. When set, it is appended toworkflow_namein the payload. Callers that don't pass it get the same message as today.upgrade-testing.yml: passesnew-version, defaulting tolatest.install-testing.yml: passeswp-version, defaulting tonightly.The version goes into the existing
workflow_namefield rather than a new payload key, because the Slack Workflow builds its message from fixed variables. A new key would not appear without editing the Slack Workflow too.Testing
actionlintpasses on the three changed files.5.1gives"Upgrade Tests (WordPress 5.1)"; an empty version gives"Upgrade Tests".WordPress/wordpress-developand not on pull requests. The commit itself triggers both workflows, so the new text should show up in #core-firehose and #core-ci-firehose on success, or #core on a failure or recovery.Trac ticket: https://core.trac.wordpress.org/ticket/66401
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the change, the local payload check, and this description; reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code