Skip to content

Build/Test Tools: Include the WordPress version in upgrade and install test Slack notifications. - #15128

Closed
lancewillett wants to merge 1 commit into
WordPress:trunkfrom
lancewillett:fix/66401-slack-notification-version
Closed

lancewillett wants to merge 1 commit into
WordPress:trunkfrom
lancewillett:fix/66401-slack-notification-version

Conversation

@lancewillett

@lancewillett lancewillett commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Adds the WordPress version under test to Slack notifications from the Upgrade Tests and Installation Tests workflows.

Before:

❗ A run of the Upgrade Tests workflow has failed for the trunk branch.

After:

❗ A run of the Upgrade Tests (WordPress 5.1) workflow has failed for the trunk branch.

Changes

  • slack-notifications.yml: new optional version input. When set, it is appended to workflow_name in the payload. Callers that don't pass it get the same message as today.
  • upgrade-testing.yml: passes new-version, defaulting to latest.
  • install-testing.yml: passes wp-version, defaulting to nightly.

The version goes into the existing workflow_name field rather than a new payload key, because the Slack Workflow builds its message from fixed variables. A new key would not appear without editing the Slack Workflow too.

Testing

  • actionlint passes on the three changed files.
  • Ran the payload step locally: 5.1 gives "Upgrade Tests (WordPress 5.1)"; an empty version gives "Upgrade Tests".
  • The Slack post itself can only be checked after commit, since the notification job runs only in WordPress/wordpress-develop and not on pull requests. The commit itself triggers both workflows, so the new text should show up in #core-firehose and #core-ci-firehose on success, or #core on a failure or recovery.

Trac ticket: https://core.trac.wordpress.org/ticket/66401

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the change, the local payload check, and this description; reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

…l test Slack notifications.

The Upgrade Tests and Installation Tests workflows can be dispatched against any WordPress version, but the Slack notifications only named the workflow and branch. Telling which version failed meant opening the run.

This adds an optional `version` input to the reusable Slack notifications workflow. When set, the version is appended to the workflow name in the payload, for example "Upgrade Tests (WordPress 5.1)". Both workflows now pass the version under test, falling back to their defaults of `latest` and `nightly`.

Props jorbin.
See #66401.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the changes adding the WordPress version under test to Slack notifications.

No open issues 🎉

What changed in this PR

Adds the WordPress version under test to Slack notifications for upgrade and installation workflows, using the existing workflow-name field.

Changes:

  • Adds an optional version input to the shared Slack workflow, preserving existing messages when omitted.
  • Passes the selected upgrade version, defaulting to latest.
  • Passes the selected installation version, defaulting to nightly.
File Description
.github/​workflows/​upgrade-testing.yml Passes the upgrade target version to Slack notifications.
.github/​workflows/​slack-notifications.yml Appends the optional WordPress version to the workflow name.
.github/​workflows/​install-testing.yml Passes the installation version to Slack notifications.

Review effort: Balanced

@lancewillett

Copy link
Copy Markdown
Member Author

wporg-sync pushed a commit that referenced this pull request Oct 29, 2026
Include the requested WordPress version in Upgrade Tests and Installation Tests notifications, using the existing `workflow_name` payload field. Keep notifications unchanged for callers that omit the optional `version` input.

Use `latest` as the default upgrade target and `nightly` as the default installation version.

Developed in: #15128

Props jorbin, lucatume.
Fixes #66401.


git-svn-id: https://develop.svn.wordpress.org/trunk@65005 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 29, 2026
Include the requested WordPress version in Upgrade Tests and Installation Tests notifications, using the existing `workflow_name` payload field. Keep notifications unchanged for callers that omit the optional `version` input.

Use `latest` as the default upgrade target and `nightly` as the default installation version.

Developed in: WordPress/wordpress-develop#15128

Props jorbin, lucatume.
Fixes #66401.

Built from https://develop.svn.wordpress.org/trunk@65005


git-svn-id: http://core.svn.wordpress.org/trunk@64155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants